[ 
https://issues.apache.org/jira/browse/DERBY-5224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13032423#comment-13032423
 ] 

Lily Wei commented on DERBY-5224:
---------------------------------

+1 The change looks good to me. I think more cohesion is better by casting. I 
also run derbyall and all tests pass with the patch.

> [patch] reduce cohesion by removing overzealous casting
> -------------------------------------------------------
>
>                 Key: DERBY-5224
>                 URL: https://issues.apache.org/jira/browse/DERBY-5224
>             Project: Derby
>          Issue Type: Improvement
>            Reporter: Dave Brosius
>            Priority: Trivial
>         Attachments: reduce_cohesion.diff
>
>
> various spots casts assignments to a type more restrictive than needed, 
> increasing cohesion. Patch reduces the casting to the required types.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to