[
https://issues.apache.org/jira/browse/DERBY-5233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13041569#comment-13041569
]
Knut Anders Hatlen commented on DERBY-5233:
-------------------------------------------
The patch looks fine to me. Two minor comments:
- The use of the success flag feels a little backwards. Perhaps it would be
clearer if we only set it to true if the operation has succeeded?
- A comment in testInterruptShutdown() says "Assert and clear thread's flag:",
but the code just below the comment doesn't clear the flag anymore. (It is
cleared further down, so only the comment needs to be updated.)
> Interrupt of create table or index (i.e. a container) will throw XSDF1 under
> NIO - connection survives
> ------------------------------------------------------------------------------------------------------
>
> Key: DERBY-5233
> URL: https://issues.apache.org/jira/browse/DERBY-5233
> Project: Derby
> Issue Type: Bug
> Affects Versions: 10.2.1.6, 10.2.2.0, 10.3.1.4, 10.3.2.1, 10.3.3.0,
> 10.4.1.3, 10.4.2.0, 10.5.1.1, 10.5.2.0, 10.5.3.0, 10.6.1.0, 10.6.2.1,
> 10.7.1.1, 10.8.1.2
> Reporter: Dag H. Wanvik
> Assignee: Dag H. Wanvik
> Attachments: DERBY-5233-1.diff, DERBY-5233-1.stat, Repro5233.java
>
>
> Cf the enclosed repro. It would be good to make Derby ignore the interrupt
> here. Cf DERBY-4741. Note that this is less serious than in the cases
> referred to in DERBY-4741: here the database does not get shut down, even the
> connection survives, cf the repro. So, this can be considered a follow-up to
> DERBY-4741 to further improve Derby's robustness under interrupts.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
