[
https://issues.apache.org/jira/browse/DERBY-5311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13059844#comment-13059844
]
Knut Anders Hatlen commented on DERBY-5311:
-------------------------------------------
The patch looks fine to me too. By the way, why was a SecurityManagerSetup
needed in this test?
I don't know, but it doesn't look like the original test was meant to test
ij.showNoConnectionsAtStart and ij.showNoCountForSelect specifically. Perhaps
we could just skip setting those properties? Then we could add ij4 directly to
one of the arrays in ToolScripts and remove the ij4Test class. Might be a
useful simplification while we're in there.
I don't see anything in the test that won't run on Java ME (except the original
connect command, which was removed by the patch), so I think it would be safe
to remove the check for JDBC.vmSupportsJSR169() and enable the test on Java ME
now.
> Convert tools/ij4.sql to junit
> -------------------------------
>
> Key: DERBY-5311
> URL: https://issues.apache.org/jira/browse/DERBY-5311
> Project: Derby
> Issue Type: Sub-task
> Components: Test
> Reporter: Houx Zhang
> Assignee: Houx Zhang
> Labels: gsoc2011
> Attachments: 5311-1.patch, 5311-1.stat
>
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
