[
https://issues.apache.org/jira/browse/DERBY-5331?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Knut Anders Hatlen updated DERBY-5331:
--------------------------------------
Attachment: reset-flush.diff
Attached a patch that adds a call to reset() before encode(), and also a call
to flush() if the encode() operation successfully encoded all characters in the
input.
Running regression tests now.
> Incorrect use of CharsetEncoder in DDMWriter
> --------------------------------------------
>
> Key: DERBY-5331
> URL: https://issues.apache.org/jira/browse/DERBY-5331
> Project: Derby
> Issue Type: Bug
> Components: Network Server
> Affects Versions: 10.4.1.3, 10.4.2.0, 10.5.1.1, 10.5.2.0, 10.5.3.0,
> 10.6.1.0, 10.6.2.1, 10.7.1.1, 10.8.1.2
> Reporter: Knut Anders Hatlen
> Attachments: reset-flush.diff
>
>
> DDMWriter has two calls to CharsetEncoder.encode(), in writeLDString() and
> writeString(). According to the javadoc for CharsetEncoder, one should call
> reset() before one calls encode(), and flush() after on. DDMWriter doesn't
> call reset() or flush(). I'm not aware of any problems that happen because of
> it, but we should follow the spec to avoid surprises.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
