[
https://issues.apache.org/jira/browse/DERBY-5342?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Houx Zhang updated DERBY-5342:
------------------------------
Attachment: 5342-8.stat
5342-8.patch
5342-7-test.patch
I have posted 5342-7-test.patch to show the problem.
When run tools._Suite, I've got the log below:
----sys.setup-------------showNoCountForSelect=true
----------script.setup()-------showNoCountForSelect=true
showNoCountForSelect=true
----------script.teardown()-------showNoCountForSelect=true
----sys.teardown-------------showNoCountForSelect=true
----sys.teardown-------------showNoCountForSelect=null
----sys.teardown-------------showNoCountForSelect=null
----sys.teardown-------------showNoCountForSelect=null
----sys.setup-------------showNoCountForSelect=null
----------script.setup()-------showNoCountForSelect=null
showNoCountForSelect=false
----------script.teardown()-------showNoCountForSelect=null
----sys.teardown-------------showNoCountForSelect=null
----sys.teardown-------------showNoCountForSelect=null
----sys.teardown-------------showNoCountForSelect=null
----sys.teardown-------------showNoCountForSelect=null
----sys.setup-------------showNoCountForSelect=null
----------script.setup()-------showNoCountForSelect=null
showNoCountForSelect=false
----------script.teardown()-------showNoCountForSelect=null
----sys.teardown-------------showNoCountForSelect=null
----sys.teardown-------------showNoCountForSelect=null
----sys.teardown-------------showNoCountForSelect=null
----sys.teardown-------------showNoCountForSelect=null
----sys.setup-------------showNoCountForSelect=null
----------script.setup()-------showNoCountForSelect=null
showNoCountForSelect=false
----------script.teardown()-------showNoCountForSelect=null
----sys.teardown-------------showNoCountForSelect=null
----sys.teardown-------------showNoCountForSelect=null
----sys.teardown-------------showNoCountForSelect=null
----sys.teardown-------------showNoCountForSelect=null
We can see that, after run IjConnNameTest, "ij.showNoCountForSelect" is set to
null. In fact, it's removed in SystemPropertyTestSetup.tearDown(). This hits a
bug in SystemPropertyTestSetup. In SystemPropertyTestSetup.setUp()
setProperties() is called, a property won't be added into oldValues if the old
value equals the new one, so the property will be removed in tearDown() later.
With 5342-8.patch, everything is OK, please check it, thanks!
> make ScriptTestCase support "ij.showNoCountForSelect" and
> "ij.showNoConnectionsAtStart"
> ---------------------------------------------------------------------------------------
>
> Key: DERBY-5342
> URL: https://issues.apache.org/jira/browse/DERBY-5342
> Project: Derby
> Issue Type: Improvement
> Components: Test
> Reporter: Houx Zhang
> Assignee: Houx Zhang
> Labels: gsoc2011
> Fix For: 10.9.0.0
>
> Attachments: 5342-1.patch, 5342-2.patch, 5342-2.stat, 5342-3.patch,
> 5342-3.stat, 5342-4-test.patch, 5342-5.patch, 5342-5.stat,
> 5342-6-testing.patch, 5342-7-test.patch, 5342-8.patch, 5342-8.stat
>
>
> Now, ScriptTestCase doesn't support property "ij.showNoConnectionsAtStart"
> (do nothing for it) and "ij.showNoCountForSelect"(it always works as
> "ij.showNoCountForSelect" = "flase").
> It will be better if the two properties be supported. To realise this,
> utilMain.goScript(Connection conn, LocalizedInput in) should be changed.
> Besides, some subclasses of ScripTestCase will be adapted accordingly.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
