Broken null checks in NsTest
----------------------------
Key: DERBY-5465
URL: https://issues.apache.org/jira/browse/DERBY-5465
Project: Derby
Issue Type: Bug
Affects Versions: 10.8.2.2
Reporter: Knut Anders Hatlen
Assignee: Knut Anders Hatlen
Priority: Minor
NsTest contains more occurrences of the broken null checking pattern found in
DERBY-5442.
Initializer.java:
if (e.getMessage().equals(null)) {
e.printStackTrace(System.out);
}
DbSetup.java:
if (e.getMessage().equals(null)) {
System.out.println("NULL error message detected");
System.out.println("Here is the NULL exection - " +
e.toString());
System.out.println("Stack trace of the NULL exception -
");
e.printStackTrace(System.out);
}
DbUtil.java:
if (e.getMessage().equals(null)) {
System.out.println(getThreadName()
+ " dbUtil --> NULL error message
detected");
System.out
.println(getThreadName()
+ " dbUtil --> Here is the NULL
exection - "
+ e.toString());
System.out.println(getThreadName()
+ " dbUtil --> Stack trace of the NULL
exception - ");
e.printStackTrace(System.out);
}
If getMessage() returns null, the null checks will throw a NullPointerException
instead of evaluating to true.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
