[ 
https://issues.apache.org/jira/browse/DERBY-5469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13130636#comment-13130636
 ] 

Rick Hillegas edited comment on DERBY-5469 at 10/19/11 5:40 PM:
----------------------------------------------------------------

Attaching derby-5469-01-ae-add17andJavadoc.diff. This patch makes it possible 
for me to build Derby and the javadoc using the open jdk 7 preview for mac os 
x. I am running regression tests against Derby jars built by this jdk in order 
to verify that the resulting jar files run correctly on Java 6.

I would appreciate it if other developers could test-drive this patch on 
Windows, Solaris, and Linux. I'm hoping that the patch allows us to use jdk 7 
on those platforms too, but some more tuning may be necessary. I would 
appreciate it if the following tests could be run:

a) Build Derby on JDK 6

b) Build javadoc on JDK 6

c) Build Derby on JDK 7

d) Build javadoc on JDK 7

This patch makes the following changes to PropertySetter:

P1) Refactors the code to make it more table-driven and eliminate duplicated 
code. These changes center around the addition of a new inner class, 
JDKVersion. That class encapsulates the information needed to set the classpath 
variable for a JDK level.

P2) Adds JDK 7 to the table of JDKVersions.

P3) Comments out the check which rejected early access releases. We may want to 
uncomment this later on. For the moment, however, I see more value than harm in 
allowing testing against early access JDKs.

P4) Adds additional logic to handle the inspection of open jdk 7 on mac os x.

P5) Expands the list of VMs which are sufficient to build Derby. Previously, 
you had to have JDK 5 or JDK 6. Now JDK 7 is sufficient to build Derby.

The patch makes the following changes to the master build script:

B1) Adds a new java17compile.classpath variable. This variable will be set by 
PropertySetter if that task finds a valid jdk 7 installation on the machine.

B2) If java16compile.classpath is not set, then set it to be 
java15compile.classpath along with the JDBC4 stubs, as was done previously. 
However, if java15compile.classpath is also not set, then 
java16compile.classpath is set to be java17compile.classpath.

B3) If java17compile.classpath is not set, then it is forced to be 
java16compile.classpath. Note that java17compile.classpath is not currently 
used by the build--but someday it may be.

B4) Increases the memory given to the javadoc tasks. Java 7 changed the javadoc 
format. The Java 7 javadoc program needs more memory--at least on mac os x it 
does.

Touches the following files:

M       java/build/org/apache/derbyPreBuild/PropertySetter.java
M       build.xml

                
      was (Author: rhillegas):
    Attaching derby-5469-01-ae-add17andJavadoc.diff. This patch makes it 
possible for me to build Derby and the javadoc using the open jdk 7 preview for 
mac os x. I am running regression tests against Derby jars built by this jdk in 
order to verify that the resulting jar files run correctly on Java 6.

I would appreciate it if other developers could test-drive this patch on 
Windows, Solaris, and Linux. I'm hoping that the patch allows us to use jdk 7 
on those platforms too, but some more tuning may be necessary. I would 
appreciate it if the following tests could be run:

a) Build Derby on JDK 6

b) Build javadoc on JDK 6

c) Build Derby on JDK 7

d) Build javadoc on JDK 7

This patch makes the following changes to PropertySetter:

P1) Refactors the code to make it more table-driven and eliminate duplicated 
code. These changes center around the addition of a new inner class, 
JDKVersion. That class encapsulates the information needed to set the classpath 
variable for a JDK level.

P2) Adds JDK 7 to the table of JDKVersions.

P3) Comments out the check which rejected early access releases. We may want to 
uncomment this later on. For the moment, however, I see more value than harm in 
allowing testing against early access JDKs.

P4) Adds additional logic to handle the inspection of open jdk 7 on mac os x.

The patch makes the following changes to the master build script:

B1) Adds a new java17compile.classpath variable. This variable will be set by 
PropertySetter if that task finds a valid jdk 7 installation on the machine.

B2) If java16compile.classpath is not set, then set it to be 
java15compile.classpath along with the JDBC4 stubs, as was done previously. 
However, if java15compile.classpath is also not set, then 
java16compile.classpath is set to be java17compile.classpath.

B3) If java17compile.classpath is not set, then it is forced to be 
java16compile.classpath. Note that java17compile.classpath is not currently 
used by the build--but someday it may be.

B4) Increases the memory given to the javadoc tasks. Java 7 changed the javadoc 
format. The Java 7 javadoc program needs more memory--at least on mac os x it 
does.

Touches the following files:

M       java/build/org/apache/derbyPreBuild/PropertySetter.java
M       build.xml

                  
> Make it possible to build Derby if you are on Mac OS X and your JDK is JDK 7
> ----------------------------------------------------------------------------
>
>                 Key: DERBY-5469
>                 URL: https://issues.apache.org/jira/browse/DERBY-5469
>             Project: Derby
>          Issue Type: Improvement
>          Components: Build tools
>            Reporter: Rick Hillegas
>            Assignee: Rick Hillegas
>         Attachments: derby-5469-01-ae-add17andJavadoc.diff
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to