[
https://issues.apache.org/jira/browse/DERBY-5469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13134169#comment-13134169
]
Rick Hillegas commented on DERBY-5469:
--------------------------------------
Thanks for test-driving the patch, Dag, Knut, and Kristian. Some responses to
Kristian's comments:
o 141: JAVA_5 is unused.
o 578: currentJDK is unused
Thanks, I will remove these.
o 1302: printProperty is unused (used for debugging?)
o 1525: requireProperty is unused
These two methods are also unused without my patch. I think that
requireProperty() is cruft which I can remove. The printProperty() method may
be useful for debugging purposes so I propose to leave it alone.
I agree that the state and methods of JDKVersion need better names and
comments. I will attempt to address this issue in the next rev of the patch.
Thanks.
> Make it possible to build Derby if you are on Mac OS X and your JDK is JDK 7
> ----------------------------------------------------------------------------
>
> Key: DERBY-5469
> URL: https://issues.apache.org/jira/browse/DERBY-5469
> Project: Derby
> Issue Type: Improvement
> Components: Build tools
> Reporter: Rick Hillegas
> Assignee: Rick Hillegas
> Attachments: derby-5469-01-ae-add17andJavadoc.diff,
> derby-5469-01-af-dontSetUprevVariables.diff
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
