[ 
https://issues.apache.org/jira/browse/DERBY-5488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13148611#comment-13148611
 ] 

Dag H. Wanvik commented on DERBY-5488:
--------------------------------------

Thanks, Rick. The limit patch looks ok to me, good you took care of that pesky 
little semantics difference in LIMIT!

Small nit: I'd change all the Boolean constructors of the kind "newBoolean( 
hasJDBClimitClause )" to
"Boolean.valueOf( hasJDBClimitClause )" for performance, cf. this comment in 
the Javadoc of valueOf:

"If a new Boolean instance is not required, this method should generally be 
used in preference to the constructor Boolean(boolean), as this method is 
likely to to yield significantly better space and time performance. "
                
> Add remaining JDBC 4.1 bits which did not appear in the Java 7 javadoc.
> -----------------------------------------------------------------------
>
>                 Key: DERBY-5488
>                 URL: https://issues.apache.org/jira/browse/DERBY-5488
>             Project: Derby
>          Issue Type: Improvement
>          Components: JDBC, SQL
>    Affects Versions: 10.9.0.0
>            Reporter: Rick Hillegas
>            Assignee: Rick Hillegas
>         Attachments: JDBC_4.1_Supplement.html, 
> derby-5488-01-aa-objectMappingAndConversion.diff, 
> derby-5488-02-aa-fixBigInteger.diff, 
> derby-5488-03-ac-moveDecimalSetterGetterAndTest.diff, 
> derby-5488-04-aa-fixBigIntegerDecimal.diff, 
> derby-5488-05-ad-limitOffset.diff, z.java
>
>
> In addition to the JDBC 4.1 bits which were visible in the Java 7 javadoc, a 
> couple other items appear in the JDBC 4.1 Maintenance Review spec. This spec 
> has been published on the JCP website at 
> http://download.oracle.com/otndocs/jcp/jdbc-4_1-mrel-eval-spec/index.html. I 
> will attach a functional spec for the remaining bits.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to