[ 
https://issues.apache.org/jira/browse/DERBY-5488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13154116#comment-13154116
 ] 

Knut Anders Hatlen commented on DERBY-5488:
-------------------------------------------

The approach in derby-5488-10-aa-metadataTypo.diff looks reasonable to me. It's 
the simplest solution, and it should be easy enough to add a release note to 
explain the impact on existing applications.

If we were to code it more defensively, I think I'd prefer to rename column 19 
to SCOPE_CATALOG and add a 25th column called SCOPE_CATLOG. That way, the 
applications that call rs.getString(19), as well as those that call 
rs.getString("SCOPE_CATLOG"), will continue to work, regardless of 
server/client versions. And so will applications that use the correctly spelled 
rs.getString("SCOPE_CATALOG"), provided that the server version is at least 
10.9.

The spec allows us to add columns this way, see this sentence in the javadoc 
for java.sql.DatabaseMetaData: "Additional columns beyond the columns defined 
to be returned by the ResultSet object for a given method can be defined by the 
JDBC driver vendor and must be accessed by their column label."
                
> Add remaining JDBC 4.1 bits which did not appear in the Java 7 javadoc.
> -----------------------------------------------------------------------
>
>                 Key: DERBY-5488
>                 URL: https://issues.apache.org/jira/browse/DERBY-5488
>             Project: Derby
>          Issue Type: Improvement
>          Components: JDBC, SQL
>    Affects Versions: 10.9.0.0
>            Reporter: Rick Hillegas
>            Assignee: Rick Hillegas
>         Attachments: JDBC_4.1_Supplement.html, 
> derby-5488-01-aa-objectMappingAndConversion.diff, 
> derby-5488-02-aa-fixBigInteger.diff, 
> derby-5488-03-ac-moveDecimalSetterGetterAndTest.diff, 
> derby-5488-04-aa-fixBigIntegerDecimal.diff, 
> derby-5488-05-ad-limitOffset.diff, derby-5488-06-aa-limitOffsetTests.diff, 
> derby-5488-07-aa-booleanObjects.diff, 
> derby-5488-08-aa-extraLimitOffsetTest.diff, 
> derby-5488-09-aa-jdbcMinorVersion.diff, derby-5488-10-aa-metadataTypo.diff, 
> fix-jdbc30-test.diff, z.java
>
>
> In addition to the JDBC 4.1 bits which were visible in the Java 7 javadoc, a 
> couple other items appear in the JDBC 4.1 Maintenance Review spec. This spec 
> has been published on the JCP website at 
> http://download.oracle.com/otndocs/jcp/jdbc-4_1-mrel-eval-spec/index.html. I 
> will attach a functional spec for the remaining bits.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to