[ 
https://issues.apache.org/jira/browse/DERBY-4845?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Knut Anders Hatlen updated DERBY-4845:
--------------------------------------

    Attachment: d4845-iapi-brokered-connection.diff

BrokeredConnection40 imports EmbedConnection40 in order to be able to call some 
JDBC 4.1 methods. Typically, we would have added the methods to the 
EngineConnection interface so that we didn't have to reference the 
implementation class directly. The problem with these methods was that they had 
java.util.concurrent.Executor in their signatures, so they couldn't be put into 
the EngineConnection interface (because it has to be compilable against the 
CDC/FP libraries, which don't have the Executor interface).

The attached patch, d4845-iapi-brokered-connection.diff, adds a new interface 
(EngineConnection40) which contains these methods. BrokeredConnection40 and 
EmbedConnection40 implement the interface. This makes it possible to access the 
methods from BrokeredConnection40 without casting the underlying connection 
instance to the implementation class EmbedConnection40.

All the regression tests ran cleanly with the patch.
                
> Improve the dependency tracking for our build targets
> -----------------------------------------------------
>
>                 Key: DERBY-4845
>                 URL: https://issues.apache.org/jira/browse/DERBY-4845
>             Project: Derby
>          Issue Type: Bug
>          Components: Build tools
>    Affects Versions: 10.8.1.2
>            Reporter: Rick Hillegas
>         Attachments: check-build.ksh, d4845-buildbreak.diff, 
> d4845-iapi-brokered-connection.diff, d4845-iapi-dependablefinder.diff, 
> d4845-iapi-nodefactory-getnode.diff, d4845-iapi-readOnlyUpgrade.diff, 
> d4845-iapi-resultsetstatistics.diff, d4845-iapi-slimmer-nodefactory.diff, 
> d4845-iapi-statementnode.diff, d4845-iapi-stmt-isClosed.diff, 
> d4845-iapi-unused-imports.diff, derby-4845-01-aa-removeParserPrep, 
> derby-4845-02-aa-flipUtilsAndTypes.diff, tools-i18n.diff
>
>
> Derby is supposed to have an incremental build. That is, if you change a 
> file, then the following command should recompile the file:
>    ant all
> There are several places in the graph of Derby build targets where this is 
> not true. If you change a file in certain packages, a subsequent "ant all" 
> won't notice the change. This issue is a place where we can track these bugs.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to