[ 
https://issues.apache.org/jira/browse/DERBY-5682?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kristian Waagan updated DERBY-5682:
-----------------------------------

    Attachment: derby-5682-1b-use_supported_encoding.diff

Thanks for looking into the naming conventions, Knut Anders.

The relevant Derby class ([1]) uses UnicodeBigUnmarked, which was what led me 
to the encoding doc. As the recommendation on this is to never remove an alias, 
I think UnicodeBigUnmarked should work for all VMs that have been around for a 
while - the fact that it is listed as a canonical name in the 
Internationalization Guide suggests so too.
However, it appears to me that it is easier to determine that UTF-16BE is 
always supported ([2]) since it is listed in the API Specification (the 
Javadocs), so I'm using it instead in patch 1b (attached).


[1] CharacterEncoding in the drda package, there's one for the client side too.
[2] The encoding doc/guide introduced UTF-16BE as a canonical name for the 
java.nio package in J2SE 1.4, whereas UnicodeBigUnmarked was the canonical name 
originally used in the Sun JDK.
                
> ProtocolTest failures: Unsupported encoding MacGreek
> ----------------------------------------------------
>
>                 Key: DERBY-5682
>                 URL: https://issues.apache.org/jira/browse/DERBY-5682
>             Project: Derby
>          Issue Type: Bug
>          Components: Test
>    Affects Versions: 10.9.0.0
>            Reporter: Knut Anders Hatlen
>            Assignee: Kristian Waagan
>            Priority: Minor
>         Attachments: derby-5682-1a-use_supported_encoding.diff, 
> derby-5682-1b-use_supported_encoding.diff
>
>
> I saw two failures in ProtocolTest when running them on a JVM where support 
> for encodings not mandated by the Java platform specification had been 
> removed.
> There were 2 failures:
> 1) 
> protocol.tests_1150_1212(org.apache.derbyTesting.functionTests.tests.derbynet.ProtocolTest)junit.framework.AssertionFailedError:
>  Unsupported encoding MacGreek
>       at 
> org.apache.derbyTesting.junit.BaseTestCase.fail(BaseTestCase.java:879)
>       at 
> org.apache.derbyTesting.functionTests.tests.derbynet.ProtocolTest.writeEncodedLDString(ProtocolTest.java:781)
>       at 
> org.apache.derbyTesting.functionTests.tests.derbynet.ProtocolTest.processCommand(ProtocolTest.java:324)
>       at 
> org.apache.derbyTesting.functionTests.tests.derbynet.ProtocolTest.processCommands(ProtocolTest.java:230)
>       at 
> org.apache.derbyTesting.functionTests.tests.derbynet.ProtocolTest.testProtocolSequence(ProtocolTest.java:148)
>       at sun.reflect.GeneratedMethodAccessor13.invoke(Unknown Source)
>       at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>       at 
> org.apache.derbyTesting.junit.BaseTestCase.runBare(BaseTestCase.java:113)
>       at junit.extensions.TestDecorator.basicRun(TestDecorator.java:24)
>       at junit.extensions.TestSetup$1.protect(TestSetup.java:23)
>       at junit.extensions.TestSetup.run(TestSetup.java:27)
>       at junit.extensions.TestDecorator.basicRun(TestDecorator.java:24)
>       at junit.extensions.TestSetup$1.protect(TestSetup.java:23)
>       at junit.extensions.TestSetup.run(TestSetup.java:27)
>       at 
> org.apache.derbyTesting.junit.BaseTestSetup.run(BaseTestSetup.java:57)
>       at junit.extensions.TestDecorator.basicRun(TestDecorator.java:24)
>       at junit.extensions.TestSetup$1.protect(TestSetup.java:23)
>       at junit.extensions.TestSetup.run(TestSetup.java:27)
>       at junit.extensions.TestDecorator.basicRun(TestDecorator.java:24)
>       at junit.extensions.TestSetup$1.protect(TestSetup.java:23)
>       at junit.extensions.TestSetup.run(TestSetup.java:27)
> Caused by: java.io.UnsupportedEncodingException: MacGreek
>       at java.lang.StringCoding.encode(StringCoding.java:340)
>       at java.lang.String.getBytes(String.java:955)
>       at 
> org.apache.derbyTesting.functionTests.tests.derbynet.ProtocolTest.writeEncodedLDString(ProtocolTest.java:774)
>       ... 41 more
> 2) 
> protocol.tests_1213_1243(org.apache.derbyTesting.functionTests.tests.derbynet.ProtocolTest)junit.framework.AssertionFailedError:
>  Unsupported encoding MacGreek
>       at 
> org.apache.derbyTesting.junit.BaseTestCase.fail(BaseTestCase.java:879)
>       at 
> org.apache.derbyTesting.functionTests.tests.derbynet.ProtocolTest.writeEncodedLDString(ProtocolTest.java:781)
>       at 
> org.apache.derbyTesting.functionTests.tests.derbynet.ProtocolTest.processCommand(ProtocolTest.java:324)
>       at 
> org.apache.derbyTesting.functionTests.tests.derbynet.ProtocolTest.processCommands(ProtocolTest.java:230)
>       at 
> org.apache.derbyTesting.functionTests.tests.derbynet.ProtocolTest.testProtocolSequence(ProtocolTest.java:148)
>       at sun.reflect.GeneratedMethodAccessor13.invoke(Unknown Source)
>       at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>       at 
> org.apache.derbyTesting.junit.BaseTestCase.runBare(BaseTestCase.java:113)
>       at junit.extensions.TestDecorator.basicRun(TestDecorator.java:24)
>       at junit.extensions.TestSetup$1.protect(TestSetup.java:23)
>       at junit.extensions.TestSetup.run(TestSetup.java:27)
>       at junit.extensions.TestDecorator.basicRun(TestDecorator.java:24)
>       at junit.extensions.TestSetup$1.protect(TestSetup.java:23)
>       at junit.extensions.TestSetup.run(TestSetup.java:27)
>       at 
> org.apache.derbyTesting.junit.BaseTestSetup.run(BaseTestSetup.java:57)
>       at junit.extensions.TestDecorator.basicRun(TestDecorator.java:24)
>       at junit.extensions.TestSetup$1.protect(TestSetup.java:23)
>       at junit.extensions.TestSetup.run(TestSetup.java:27)
>       at junit.extensions.TestDecorator.basicRun(TestDecorator.java:24)
>       at junit.extensions.TestSetup$1.protect(TestSetup.java:23)
>       at junit.extensions.TestSetup.run(TestSetup.java:27)
> Caused by: java.io.UnsupportedEncodingException: MacGreek
>       at java.lang.StringCoding.encode(StringCoding.java:340)
>       at java.lang.String.getBytes(String.java:955)
>       at 
> org.apache.derbyTesting.functionTests.tests.derbynet.ProtocolTest.writeEncodedLDString(ProtocolTest.java:774)
>       ... 41 more

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to