[
https://issues.apache.org/jira/browse/DERBY-5683?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Knut Anders Hatlen updated DERBY-5683:
--------------------------------------
Attachment: d5683-1a-close-and-forget.diff
Attaching a patch that makes getDatabaseProperty() close the ResultSet and
PreparedStatement before returning the property value. It also removes the
PreparedStatement from the list of statements to close at tearDown(). With
these changes, AuthenticationTest completes successfully in my environment when
running with -Xmx64.
> BaseJDBCTestCase.getDatabaseProperty() should close resources before returning
> ------------------------------------------------------------------------------
>
> Key: DERBY-5683
> URL: https://issues.apache.org/jira/browse/DERBY-5683
> Project: Derby
> Issue Type: Improvement
> Components: Test
> Affects Versions: 10.9.0.0
> Reporter: Knut Anders Hatlen
> Assignee: Knut Anders Hatlen
> Priority: Minor
> Attachments: d5683-1a-close-and-forget.diff
>
>
> BaseJDBCTestCase.getDatabaseProperty() creates a PreparedStatement and a
> ResultSet that are not closed before the method returns. If a test case calls
> getDatabaseProperty() many times, the open statements may have a big memory
> footprint.
> This can be seen for example by running jdbcapi.AuthenticationTest with
> -Xmx64. It will fail with an OutOfMemoryError when
> testNoCollisionsWithConfigurableHash() runs in client/server mode.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
