[ 
https://issues.apache.org/jira/browse/DERBY-5637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13251426#comment-13251426
 ] 

Knut Anders Hatlen commented on DERBY-5637:
-------------------------------------------

Thanks Kim, for getting this into the docs, and John, for writing it up in the 
first place!

It all looks good to me. Some minor questions/suggestions below. Feel free to 
commit the patch as-is and address the comments in a follow-up.

- In the "Using custom Java code to access the Derby MBeans" topic, the 
sentence "It is assumed that the client JVM supports Java SE 5, 6, or 7" is 
redundant since the client driver only works on Java SE 5 and newer, starting 
with Derby 10.9, so the version requirement isn't JMX-specific. Removing the 
sentence has the additional benefit that we don't have to update it once Java 8 
is out. :)

- "Disabling access to MBeans" references and shows code from an internal 
method (JMXManagementService.jmxRegister()). Maybe it's enough to say that 
without the permissions, Derby will silently skip starting the management 
service at boot time? Hopefully, the users believe that statement even if we 
don't include the code to prove it. ;)

- "Enabling and disabling JMX" topic:

  * Maybe change "running as the same user" to "running as the same operating 
system user" so that it's not confused with Derby database or system users?

  * Change "If you are using a Java SE 6 or 7 JVM" to "If you are using a Java 
SE 6 or newer JVM" to prevent need to update as new JVM versions are released?

- "Introduction to the Derby MBeans" topic: Should we remove the parts marked 
"(not public)" to keep them private?

- "Troubleshooting JMX connection issues" topic: "It" (first sentence, after 
the comma) should not be capitalized.

- Inconsistent casing: "Platform MBean Server" / "platform MBean server" / 
"platform MBean Server"
                
> Document Derby's JMX capabilities and how to disable them
> ---------------------------------------------------------
>
>                 Key: DERBY-5637
>                 URL: https://issues.apache.org/jira/browse/DERBY-5637
>             Project: Derby
>          Issue Type: Improvement
>          Components: Documentation, JMX
>    Affects Versions: 10.9.0.0
>            Reporter: Rick Hillegas
>            Assignee: Kim Haase
>         Attachments: DERBY-5637.diff, DERBY-5637.stat, DERBY-5637.zip
>
>
> Derby's JMX beans are useful, although limited. We should document their 
> capabilities as well as how to disable/restrict access to them in 
> security-conscious environments.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to