[
https://issues.apache.org/jira/browse/DERBY-5749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13275911#comment-13275911
]
Knut Anders Hatlen commented on DERBY-5749:
-------------------------------------------
The patches look good to me.
Nits:
- There's a typo in the comment in DMLModStatementNode: "implicit case" ->
"implicit case".
- You might want to test an update statement too in test_derby_5749(). One that
increases the length of a value in column B so that the auto-generated value in
column C gets too long.
> Implicit cast of variable length values, e.g. as arguments to stored methods
> and generated columns values, silently truncate if too long
> ----------------------------------------------------------------------------------------------------------------------------------------
>
> Key: DERBY-5749
> URL: https://issues.apache.org/jira/browse/DERBY-5749
> Project: Derby
> Issue Type: Bug
> Components: JDBC, SQL
> Affects Versions: 10.0.2.0, 10.0.2.1, 10.1.1.0, 10.1.2.1, 10.1.3.1,
> 10.2.1.6, 10.2.2.0, 10.3.1.4, 10.3.2.1, 10.3.3.0, 10.4.1.3, 10.4.2.0,
> 10.5.1.1, 10.5.2.0, 10.5.3.0, 10.6.1.0, 10.6.2.1, 10.7.1.1, 10.8.1.2, 10.8.2.2
> Reporter: Dag H. Wanvik
> Assignee: Dag H. Wanvik
> Attachments: DERBY-5749-2.diff, DERBY-5749-2.stat, DERBY-5749.diff,
> DERBY-5749.stat, DERBY-5749b.diff, DERBY-5749b.stat,
> SilentVarcharArgTruncation.java, SilentVarcharArgTruncation.java
>
>
> Cf the attached repro SilentVarcharArgTruncation.
> It seem implicit casts are inserted here, cf discussion on derby-dev thread
> starting here:
> http://mail-archives.apache.org/mod_mbox/db-derby-dev/201205.mbox/%3Cx67gwm7hir.fsf%40oracle.com%3E
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
