[ 
https://issues.apache.org/jira/browse/DERBY-5764?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kristian Waagan updated DERBY-5764:
-----------------------------------

    Attachment: derby-5764-2a-specify_schema.diff

Attaching patch 2a, which causes the user name to be used as the schema name.

Initially I had the schema name as a static variable, but that caused some 
extra complexity for no gain since it must be possible to use two different 
schema names during a run of suites.All (running the test individually, and as 
part of the upgrade tests). I found that the schema name only has to stay 
constant for the duration of a fixture.

Running the full regression suite for good measure.
Patch ready for review.

As mentioned in the thread on derby-dev, the next step would be to add some 
extra tests to compensate for the coverage lost by always specifying a schema 
in the queries.
                
> Make DatabaseMetaDataTest more robust wrt changes made by other tests
> ---------------------------------------------------------------------
>
>                 Key: DERBY-5764
>                 URL: https://issues.apache.org/jira/browse/DERBY-5764
>             Project: Derby
>          Issue Type: Improvement
>          Components: Test
>    Affects Versions: 10.9.0.0
>            Reporter: Kristian Waagan
>            Assignee: Kristian Waagan
>            Priority: Minor
>         Attachments: derby-5764-1a-upgraderun_cleanup.diff, 
> derby-5764-2a-specify_schema.diff
>
>
> The subset of tests from DatabaseMetaDataTest being run as part of the 
> upgrade tests is sensitive to changes in the database made by other tests. 
> For instance, adding tables with foreign keys will make the test fail due to 
> extra rows in system tables.
> Usually this could be solved by using a single-use db wrapper of some sort, 
> but in the upgrade tests the database will be booted several times with 
> different versions of Derby and the data needs to be preserved between some 
> of these boots.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to