[ 
https://issues.apache.org/jira/browse/DERBY-5213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13445114#comment-13445114
 ] 

Mike Matrigali commented on DERBY-5213:
---------------------------------------

the tests in the preliminary patch look good.  This is just from a reading of 
the code, did not compile/run it.

Some nits:
o would be nice to have hdr comment on testUncommittedTruncateBackupEnableLog
o assertDirectoryDeleted() seems like something that should be in a test 
utility that could be
   used in all tests rather than specific tests.

stuff that should not hold up a commit:
o An interesting test would be to have truncate table happen "during the 
backup".  This is a lot harder to write as timing is very
   critical.  Spent some time thinking about this but could not come up with a 
user level code way to test this for sure.  Could 
   hack the actual code to help testing but that is not a great idea.  
o could add tests of freeze and unfreeze with respect to truncate.

                
> Write tests to verify the interaction of TRUNCATE TABLE and online backup
> -------------------------------------------------------------------------
>
>                 Key: DERBY-5213
>                 URL: https://issues.apache.org/jira/browse/DERBY-5213
>             Project: Derby
>          Issue Type: Task
>          Components: SQL, Store
>    Affects Versions: 10.9.1.0
>            Reporter: Rick Hillegas
>            Assignee: Myrna van Lunteren
>         Attachments: DERBY_5213.diff_1
>
>
> An uncommitted TRUNCATE TABLE command does not block online backup. We should 
> verify that the online and backed up databases are both in a consistent 
> state. At a minimum, we should test the following:
> o uncommitted truncate table followed by online backup and then access the 
> backup copy and access the table.  should see the old data.
> o uncommitred truncate table, followed by online backup that keeps logs,
>   then commit the truncate, and then access the table in the backup.
> For more information, please see this email thread: 
> http://old.nabble.com/truncating-a-table-vs-online-backup-to31524933.html#a31524933

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to