[
https://issues.apache.org/jira/browse/DERBY-5910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13478041#comment-13478041
]
Rick Hillegas commented on DERBY-5910:
--------------------------------------
Thanks for the second patch, Kim. Looks great. Some comments:
cdevconcepts839085
o Fourth paragraph: "Derby will attempt to close" ->
"the JRE will attempt to close"
o Fifth paragraph: "an an" -> "an"
o Same paragraph. I would say "Derby will not close" rather than
"Derby will fail to close" because the second phrase suggests to me
that Derby is doing something wrong.
rrefjdbc27734
o Third paragraph: "Derby will attempt to close" ->
"the JRE will attempt to close"
o Fourth paragraph: "an an" -> "an"
o Same paragraph. I would say "Derby will not close" rather than
"Derby will fail to close" because the second phrase suggests to me
that Derby is doing something wrong.
Thanks,
-Rick
> Document use of Connection.close() with try-with-resources
> ----------------------------------------------------------
>
> Key: DERBY-5910
> URL: https://issues.apache.org/jira/browse/DERBY-5910
> Project: Derby
> Issue Type: Improvement
> Components: Documentation
> Affects Versions: 10.9.1.0
> Reporter: Kim Haase
> Assignee: Kim Haase
> Attachments: DERBY-5910-2.diff, DERBY-5910-2.zip, DERBY-5910.diff,
> DERBY-5910.stat, DERBY-5910.zip
>
>
> The Java SE 7 try-with-resources feature can cause problems with
> AutoCloseable objects like java.sql.Connection. You must be careful when
> writing portable code which declares Connections in the initializers of
> try-with-resources blocks, because Derby raises an exception if you try to
> close a Connection with uncommitted work in-flight.
> Changing Derby's Connection.close() to always commit in-flight work (and not
> raise an exception) would create backward compatibility issues, but we do not
> know yet how serious these issues would be, owing to a lack of data.
> Rather than change Derby's behavior now, we should document how Derby's
> Connection.close() behaves and describe the portability issues involved in
> declaring Derby Connections in try-with-resources initializers.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
