[
https://issues.apache.org/jira/browse/DERBY-672?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rick Hillegas updated DERBY-672:
--------------------------------
Attachment: derby-672-17-aa-moreTests.diff
Attaching derby-672-17-aa-moreTests.diff. This patch adds negative tests for
more illegal uses of user-defined aggregates. Along the way, some code had to
be corrected. Tests ran cleanly for me. Committed at subversion revision
1400083.
Touches the following files:
-----------
M java/engine/org/apache/derby/impl/sql/compile/AggregateNode.java
Changes some error messages to use the schema-qualified name of the
user-defined aggregate rather than the name of the class it is bound to.
-----------
M java/engine/org/apache/derby/impl/sql/compile/ConditionalNode.java
I was seeing NPEs when using user-defined aggregates in CASE expressions for
the following reason: although the aggregate-bearing clauses were being bound
in isolation, the bound forms weren't being substituted back into the larger
expression tree. I corrected this by putting the bound forms back into the tree.
-----------
M
java/testing/org/apache/derbyTesting/functionTests/tests/lang/UserDefinedAggregatesTest.java
Additional test cases.
> Re-enable user defined aggregates
> ---------------------------------
>
> Key: DERBY-672
> URL: https://issues.apache.org/jira/browse/DERBY-672
> Project: Derby
> Issue Type: Improvement
> Components: SQL
> Reporter: Rick Hillegas
> Assignee: Rick Hillegas
> Attachments: derby-672-01-aa-ddl.diff,
> derby-672-02-ac-nonDistinct.diff, derby-672-03-aa-distinct.diff,
> derby-672-03-ab-distinct.diff, derby-672-04-aa-fixJSR169test.diff,
> derby-672-05-aa-java7testOrderProblem.diff, derby-672-06-aa-grantRevoke.diff,
> derby-672-07-aa-fixJSR169again.diff, derby-672-08-aa-fixJSR169yetAgain.diff,
> derby-672-09-ab-udtAggregates.diff, derby-672-10-af-typeBounds.diff,
> derby-672-11-aa-tests.diff, derby-672-11-ab-tests.diff,
> derby-672-12-aa-implicitCasts.diff, derby-672-13-aa-differentReturnType.diff,
> derby-672-14-aa-collations.diff, derby-672-15-aa-setCollation.diff,
> derby-672-16-aa-forbidInGroupBy.diff, derby-672-17-aa-moreTests.diff,
> UserDefinedAggregates.html, UserDefinedAggregates.html,
> UserDefinedAggregates.html
>
>
> Nicolas Dufour in an email thread titled "functions and list" started on
> November 2, 2005 requests the ability to create user defined aggregates.
> This functionality used to be in Cloudscape. It was disabled presumably
> because it was considered non-standard. However, most of the machinery needed
> for this feature is still in the code. We should re-enable user defined
> aggregates after we agree on acceptable syntax.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
