[ 
https://issues.apache.org/jira/browse/DERBY-5962?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Knut Anders Hatlen updated DERBY-5962:
--------------------------------------

    Attachment: d5962-1a.diff

Attaching a patch for this issue.

The patch removes these messages for decryption failures:

XBCXX.S: Database decryption failed: {0}
XBCXY.S: Cannot decrypt database because of the database state: {0}

Instead of passing a detailed message as an argument to those messages, one of 
the more specific messages for encryption is used. That is, one of these four, 
depending on the actual failure (they've been adjusted to also mention 
decryption):

XBCXO.S: Cannot encrypt, re-encrypt or decrypt the database when there is a 
global transaction in the prepared state.
XBCXQ.S: Cannot encrypt, re-encrypt or decrypt a read-only database.
XBCXS.S: Cannot encrypt, re-encrypt or decrypt a database when it is in the log 
archive mode.
XBCXU.S: Encryption, re-encryption or decryption of a database failed: {0}

The above messages were also adjusted to mention re-encryption, so that the 
following four messages could be removed by the patch:

XBCXP.S: Cannot re-encrypt the database with a new boot password or an external 
encryption key when there is a global transaction in the prepared state.
XBCXR.S: Cannot re-encrypt a read-only database with a new boot password or an 
external encryption key .
XBCXT.S: Cannot re-encrypt a database with a new boot password or an external 
encryption key, when database is in the log archive mode.
XBCXV.S: Encryption of an encrypted database with a new key or a new password 
failed: {0}

Since the removed messages for re-encryption have been replaced with messages 
that have different SQL states, we would need a release note if we make that 
change.

The patch updates the canons for store/encryptDatabaseTest2.sql and 
store/encryptDatabaseTest3.sql with the new messages. It also adds test cases 
for decryption to those tests to verify that we get the expected messages.

All the regression tests passed with the patch.
                
> Internationalize error messages for database decryption
> -------------------------------------------------------
>
>                 Key: DERBY-5962
>                 URL: https://issues.apache.org/jira/browse/DERBY-5962
>             Project: Derby
>          Issue Type: Sub-task
>          Components: Store
>            Reporter: Knut Anders Hatlen
>            Assignee: Knut Anders Hatlen
>         Attachments: d5962-1a.diff
>
>
> Some of the error messages for database decryption (DERBY-5792) are not fully 
> internationalized, as they take a hard-coded English message as an argument. 
> We should make the messages come from messages.xml so that they can be 
> localized.
> As discussed in DERBY-5792, we may also want to merge the messages for 
> encryption, re-encryption and decryption to reduce the total number of 
> messages.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to