[
https://issues.apache.org/jira/browse/DERBY-2920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13494120#comment-13494120
]
Mike Matrigali commented on DERBY-2920:
---------------------------------------
thanks for running the tests, i think it is ok to check this in. I set my low
limit at around .3-.4 % for a code change like this where it was a
share/codesize vs performance issue. and higher if the change was more
complicated rather than just hand inlining code, ...
I remember now that these routines would also show much higher for some
profilers vs deliverable performance runs. So the change may make it a little
harder to determine where you can
get real performance wins. Again this is old profiler, especially those that
had to instrument each routine to get their results. Again I think it ok to
check in, just noting this in case it can help
anyone in the future if they see readExternal...() showing up high in profiles.
> Share code between readExternal() and readExternalFromArray()
> -------------------------------------------------------------
>
> Key: DERBY-2920
> URL: https://issues.apache.org/jira/browse/DERBY-2920
> Project: Derby
> Issue Type: Improvement
> Components: Services, SQL
> Reporter: Knut Anders Hatlen
> Assignee: Knut Anders Hatlen
> Priority: Minor
> Labels: derby_triage10_10
> Fix For: 10.10.0.0
>
> Attachments: d2920-1a.diff, ReadInts2.java, ReadInts.java
>
>
> Most of the implementations of
> DataValueDescriptor.readExternalFromArray(ArrayInputStream) are identical to
> their corresponding Externalizable.readExternal(ObjectInput) methods. Since
> ArrayInputStream implements ObjectInput, readExternalFromArray() could in
> those cases just have forwarded calls to readExternal() instead of
> duplicating the code. A default forwarding implementation of
> readExternalFromArray() could be placed in
> org.apache.derby.iapi.types.DataType, and all the existing implementations,
> except those with optimizations for ArrayInputStream, could be removed.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
