[
https://issues.apache.org/jira/browse/DERBY-5955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13533877#comment-13533877
]
Knut Anders Hatlen commented on DERBY-5955:
-------------------------------------------
The version 2 patch seems to preserve the original functionality and
interfaces, as far as I can tell, and I think the new hierarchy is better
structured, so it looks like a net improvement to me.
There seems to be one added piece of functionality in the patch:
EmbeddedSimpleDataSource now implements the setAttributesAsPassword() method
supported by the other embedded data sources. But that looks like an
improvement too.
Some minor comments:
- There's some odd formatting. Most of it because already poorly formatted code
was moved (like the equals() method moved from EmbeddedDataSource to
EmbeddedBaseDataSource). And in EmbeddedDataSourceInterface the indentation
alternates between 3 and 4. I see you've already removed tabs from the
copied/moved code. Maybe you can take it one step further and tell your
favourite IDE to reformat the entire EmbeddedBaseDataSource and
EmbeddedDataSourceInterface files? Since those are new files, reformatting them
won't make archeology any harder.
- A static field STRING_ARG is added to EmbeddedDataSource, but it's never used.
- Some code is added to the JDBCDataSource test in order to preserve stack
trace and exception chain in case of failure. Would a call to
BaseTestCase.fail(String,Throwable) do the same trick?
> Prepare Derby to run with Compact Profiles (JEP 161)
> ----------------------------------------------------
>
> Key: DERBY-5955
> URL: https://issues.apache.org/jira/browse/DERBY-5955
> Project: Derby
> Issue Type: Improvement
> Components: Documentation, JDBC, Services, SQL
> Reporter: Dag H. Wanvik
> Assignee: Dag H. Wanvik
> Attachments: apidiff.zip, client-graph.png,
> derby-5955-embed-restructure-01.diff, derby-5955-embed-restructure-01.stat,
> derby-5955-embed-restructure-02.diff, derby-5955-embed-restructure-02.stat,
> derby-5955-proof-of-concept-2.diff, derby-5955-proof-of-concept-2.stat,
> derby-5955-proof-of-concept.diff, derby-5955-proof-of-concept.stat,
> derby-5955-ser.zip, embedded-graph.png, old-client-graph.png,
> old-embedded-graph.png, publishedapi.zip, publishedapi.zip
>
>
> While waiting for a Java module system (aka project Jigsaw), it has been
> decided to define a few subsets of the Java SE Platform Specification, cf JEP
> 161 ( http://openjdk.java.net/jeps/161).
> A quote from the JEP: "More broadly, this feature is intended to enable the
> migration of applications currently built on top of the Java ME Connected
> Device Configuration (CDC) to appropriate Profiles of the Java SE Platform,
> part of the long-term effort to converge CDC with Java SE."
> It would be good if we make Derby to run on such limited profiles. The
> current proposal places JDBC in Compact Profile 2 (cf. link above), while
> other libraries used by Derby, e.g. javax.naming (JNDI) are in Profile 3
> (larger).
> It would be good if Derby could run on the smallest posible platform, i.e.
> Profile 2, but that will probably involve some changes to make Derby
> gracefully limit functionality when some libraries are missing.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
