[
https://issues.apache.org/jira/browse/DERBY-5955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13558625#comment-13558625
]
Knut Anders Hatlen commented on DERBY-5955:
-------------------------------------------
Thanks, Dag. The changes in the make-tests-run-03 patch look good to me. Some
further comments and questions:
DataSourceSerializationTest.java:
- Would it make sense to test the non-JNDI data sources also if the JVM does
support JNDI? Then those who run tests in environments that do support JNDI
might notice earlier if they've broken the non-JNDI data sources.
- I think this check is too broad and unintentionally disables testing of JDBC
4 data sources on platforms that support JDBC 4 (vmSupportsJDBC3() returns true
in JDBC 4 environments):
if (JDBC.vmSupportsJDBC3() && className.contains("40")) {
// Running old Java, bail out if JDBC4
return;
}
- Some JNDI code in deSerializeDs() had to be rewritten using reflection to
prevent the JVM from trying to load JNDI classes even if the code was never
executed. Out of curiosity, do you know what makes reflection necessary in this
code and not in, for example, Wrapper41DataSource, which accesses the JNDI data
sources without reflection?
> Prepare Derby to run with Compact Profiles (JEP 161)
> ----------------------------------------------------
>
> Key: DERBY-5955
> URL: https://issues.apache.org/jira/browse/DERBY-5955
> Project: Derby
> Issue Type: Improvement
> Components: Documentation, JDBC, Services, SQL
> Reporter: Dag H. Wanvik
> Assignee: Dag H. Wanvik
> Attachments: apidiff.zip, client-graph.png,
> derby-5955-add-cp2-to-jars.diff, derby-5955-client-restructure-01.diff,
> derby-5955-client-restructure-01.stat,
> derby-5955-client-restructure-02-delta.diff,
> derby-5955-client-restructure-02.diff, derby-5955-client-restructure-02.stat,
> derby-5955-embed-restructure-01.diff, derby-5955-embed-restructure-01.stat,
> derby-5955-embed-restructure-02.diff, derby-5955-embed-restructure-02.stat,
> derby-5955-embed-restructure-03.diff, derby-5955-embed-restructure-03.stat,
> derby-5955-embed-restructure-04.diff, derby-5955-embed-restructure-04.stat,
> derby-5955-embed-restructure-followup.diff,
> derby-5955-embed-restructure-followup.stat,
> derby-5955-make-tests-run-01.diff, derby-5955-make-tests-run-01.stat,
> derby-5955-make-tests-run-02.diff, derby-5955-make-tests-run-02.stat,
> derby-5955-make-tests-run-03.diff, derby-5955-new-non-jndi-ds-01.diff,
> derby-5955-new-non-jndi-ds-01.stat, derby-5955-new-non-jndi-ds-02.diff,
> derby-5955-new-non-jndi-ds-02.stat, derby-5955-proof-of-concept-2.diff,
> derby-5955-proof-of-concept-2.stat, derby-5955-proof-of-concept.diff,
> derby-5955-proof-of-concept.stat, derby-5955-ser-b.zip, derby-5955-ser.zip,
> embedded-graph.png, old-client-graph.png, old-embedded-graph.png,
> publishedapi.zip, publishedapi.zip
>
>
> While waiting for a Java module system (aka project Jigsaw), it has been
> decided to define a few subsets of the Java SE Platform Specification, cf JEP
> 161 ( http://openjdk.java.net/jeps/161).
> A quote from the JEP: "More broadly, this feature is intended to enable the
> migration of applications currently built on top of the Java ME Connected
> Device Configuration (CDC) to appropriate Profiles of the Java SE Platform,
> part of the long-term effort to converge CDC with Java SE."
> It would be good if we make Derby to run on such limited profiles. The
> current proposal places JDBC in Compact Profile 2 (cf. link above), while
> other libraries used by Derby, e.g. javax.naming (JNDI) are in Profile 3
> (larger).
> It would be good if Derby could run on the smallest posible platform, i.e.
> Profile 2, but that will probably involve some changes to make Derby
> gracefully limit functionality when some libraries are missing.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
