You can kill the patch and someone at some point maybe will actually fix it the way you're looking for. No need to drag on the convo, I get the point and no one (other than me) is arguing against you. It seems like we're in an age where one person's opinion can block commits/ideas - so go ahead and kill it. I don't have the time or know how to do it the way you want so I'll just keep the patch local so I can actually use my ruler on a dark theme.
On 12/11/2015 08:52 AM, V Stuart Foote wrote: >> Fri 2015-12-11 8:36 AM, Joel Madero wrote: >> >> On 12/11/2015 04:51 AM, Christian Lohmaier wrote: >>> @Joel: >>> " I changed DarkShadowColor (which is worthless for dark themes) to >>> DeactivatedColor (light gray)." >>> >>> hope to Deactive*Text*Color :-) >> Nope I actually tried DeactiveTextColor and it was too light for lighter >> themes (that was actually light gray). I then tried DeactiveColor (which >> is just gray) and it looks okay on both. > I don't think tweaking one or two of the color assignments associated with > Ruler in hopes of having it look good in both light and dark color > schemes/themes is going to be viable. Also there is chance of disrupting > color assignment actions when Assistive Technology tools are active and HC > is detected active on the OS--found in app/settings.cxx (just parts of the > default colorshceme get tweaked along with the change to HC icons). > > Unfortunately, kind of believe that Joel's simple color change to the ruler > substituting GetDeactiveColor() for GetDarkShadowColor() is going to result > in a non-crisp/lower contrast ruler in both Light and Dark color schemes. > > Issue has been that colors of the ruler pulled from colors of named elements > in styles, usually the default colorscheme, can only be adjusted in source > as Joel just has done. It really seems that to do this correctly the half > dozen color assignment(s) for the Ruler (in ruler.cxx) should be > individually exposed for assignment in the Application Colors (General > section as an Enchanced color scheme) along with Expert Config > :EnhancedColorScheme stanzas. > > They then would be exposed for users to edit in their > registrymodifications.xcu > > > > -- > View this message in context: > http://nabble.documentfoundation.org/Rule-Colors-Color-Change-Needs-Review-tp4168960p4169060.html > Sent from the Design mailing list archive at Nabble.com. > -- To unsubscribe e-mail to: [email protected] Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://listarchives.libreoffice.org/global/design/ All messages sent to this list will be publicly archived and cannot be deleted
