On Tue, Jul 29, 2014 at 11:07 PM, Jon Robson <[email protected]> wrote:
> I like the idea of each change requiring a +1 from the main teams that > use it (which I think are Flow, Growth and Mobile correct me if wrong). > Yeahhh, that would definitely be worth considering – I just noticed this change show up on the mobile site, and it has a few mobile-specific bugs that need to get ironed out (I reported the issues on BZ: https://bugzilla.wikimedia.org/show_bug.cgi?id=69724). Always good to get at least one MFE engineer's eyes on any change likely to affect mobile before it gets merged; it's either that or the much more ambitious goal of getting every WMF engineer to remember to test user-facing changes vigorously on phones and tablets (which I do hope we'll get to one day...) ;) > e.g. +3 :) I'm happy to see mobile, Flow and growth caring about the same > problems and things getting merged more rapidly then we have done > previously. I'm keen to keep this momentum. > > Maybe its worth getting together people not going to Wikimania and getting > mw-ui-input styling resolved in a way that makes everyone happy and keeps > the solution generalised and consistent ? > > We may also want to consider a beta concept of mediawiki ui that allows us > to hide experimental styling behind additional modifier classes. I'm keen > for teams to rapidly prototype and experiment with new design ideas but to > do so in a way that keeps compatibility. e.g. mw-ui-beta .mw-ui-button > On 29 Jul 2014 22:08, "Shahyar Ghobadpour" <[email protected]> > wrote: > >> On Tue, Jul 29, 2014 at 4:29 PM, Steven Walling <[email protected]> >> wrote: >>> >>> I'm glad we merged this sooner rather than later, since it means there >>> are fewer Flow-specific overrides on top of mediawiki.ui and it forces us >>> to have a cross-team discussion. >>> >> >> Flow doesn't use overrides on top of mediawiki.ui (except for >> mw-ui-button, which only started recently). We wrote all mw-ui components >> independently of Core, using a flow-ui prefix -- including a rewrite of >> mw-ui-button, which I felt had become too messy and confusing. When I felt >> that the flow-ui versions had reached a certain level of maturity, I'd put >> them for review into Core's gerrit as mw-ui components. >> >> >> On Tue, Jul 29, 2014 at 11:16 PM, Erik Moeller <[email protected]> >> wrote: >>> >>> I agree we have to be wary about consistency. I'm not sure putting >>> these kinds of changes on the release train incrementally is the way >>> to go -- perhaps having a test instance in Labs run a WIP changeset or >>> branch til we're happy with it, including things like RTL testing? >> >> >> This is specifically the reason I was using Flow as the testbed to >> develop and iterate upon the mw-ui components. However, I think my team >> jumped the gun on putting this into Core without fully testing all of the >> use cases. I take responsibility for this, as I should have been more >> careful to a) include i18n people in the design mocks, and b) thoroughly >> test any current uses of affected mw-ui components being moved to Core. >> >> >> Going forward, I think we will need to shift from a single +2 in gerrit, >> to a +1 from several teams (perhaps Flow, Growth, Mobile, and Language), >> before approving a merge to Core. For these mediawiki.ui design goals to >> succeed, we'll need to make sure we have our primary bases covered via >> these teams. >> >> --Shahyar >> >> >> _______________________________________________ >> Design mailing list >> [email protected] >> https://lists.wikimedia.org/mailman/listinfo/design >> >> > _______________________________________________ > Design mailing list > [email protected] > https://lists.wikimedia.org/mailman/listinfo/design > > -- Maryana Pinchuk Product Manager, Wikimedia Foundation wikimediafoundation.org
_______________________________________________ Design mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/design
