Public bug reported: Binary package hint: rhythmbox
I noticed this when Rhythmbox attempted to load files outside the MUSIC/ directory on my iAudio and threw a bunch of import errors. It turns out it's been reported and fixed in upstream SVN. The patch should be easily backportable. According to the upstream bug, it can cause Rhythmbox to crash, so this should be fixed for release. I can't figure out how to link it to the upstream bug, so it's here: http://bugzilla.gnome.org/show_bug.cgi?id=505340 The description there is: This problem is present in the file plugins/generic-player/rb-generic-player-source.c The function load_songs (line 709) uses folders that were determined by HAL and saved into the priv variable (line 725). However HAL loads the variable after load_songs is called (see line 223, get_device_info loads the priv variable), so load_songs never has the audio_folders. This can cause rhythmbox to crash when the generic player contains music only in the folders determined by HAL and stored in audio_folders. Calling get_device_info before load_songs fixes the problem. I attached the simple patch. The patch to which he refers can be found on the original GNOME Bugzilla page. ** Affects: rhythmbox (Ubuntu) Importance: Undecided Status: New ** Summary changed: - Rhythmbox loads songs before checking which directories to load from + [Hardy] Rhythmbox loads songs before checking which directories to load from ** Description changed: Binary package hint: rhythmbox I noticed this when Rhythmbox attempted to load files outside the MUSIC/ directory on my iAudio and threw a bunch of import errors. It turns out it's been reported and fixed in upstream SVN. The patch should be easily backportable. + + According to the upstream bug, it can cause Rhythmbox to crash, so this + should be fixed for release. + + I can't figure out how to link it to the upstream bug, so it's here: http://bugzilla.gnome.org/show_bug.cgi?id=505340 + The description there is: + This problem is present in the file + plugins/generic-player/rb-generic-player-source.c + + The function load_songs (line 709) uses folders that were determined by HAL and + saved into the priv variable (line 725). However HAL loads the variable after + load_songs is called (see line 223, get_device_info loads the priv variable), + so load_songs never has the audio_folders. + + This can cause rhythmbox to crash when the generic player contains music only + in the folders determined by HAL and stored in audio_folders. + + Calling get_device_info before load_songs fixes the problem. I attached the + simple patch. + + + The patch to which he refers can be found on the original GNOME Bugzilla page. -- [Hardy] Rhythmbox loads songs before checking which directories to load from https://bugs.launchpad.net/bugs/202405 You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to rhythmbox in ubuntu. -- desktop-bugs mailing list [email protected] https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
