Gunnar, finally I have some time to get back to this. I looked at your recent gdm patch, and have some questions:
- in language_update(), why do we need the "en" special case? - in the second part of language_update(), why would $GDM_LANG not be a valid locale? this does some rather expensive things like locale -a and grep and iterating over all available locales. So far we trusted that $GDM_LANG was the format of a locale name, and also a valid locale (gdm already tests that); under that assumption, couldn't we simply set $LC_MESSAGES to $GDM_LANG? - in the new_language check at the bottom, I think we should additionally check that $GDM_LANG != $LANG; for people who already have $LANG set to $GDM_LANG (as we do in our installer by default, etc.) there is IMHO no reason to change anything in the environment or do any expensive operations. - in the final patch I'd like to replace some external program calls (expr, grep) with internal shell constructs for efficiency; that's just a FYI, though Thanks! Martin -- Set $LANGUAGE if the user picks a different locale in gdm, so that language-selector and gdm stop disagreeing https://bugs.launchpad.net/bugs/553162 You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to gdm in ubuntu. -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
