(In reply to Albert Astals Cid from comment #74) > (In reply to Adrian Johnson from comment #73) > > (In reply to Albert Astals Cid from comment #72) > > > > Large file support. > > > > > > Do you think this should be a blocker for the initial release or something > > > we can improve later? > > > > I think it should be included. > > Do you have any file like that or a way to create it so the guys can test it?
I don't have a file. Bug 44085 contains a large file test case. But I don't know how to sign it. Implementing large file support is simply a case of using obj.isInt64()/ obj.getInt64() when getting the range offsets. In addition, the code should avoid reading the entire range into memory instead processing it in smaller chunks. From a quick look a the nss headers it appears to have support for incremental hashing. This is good practice even for < 2GB files as I have seen scanned PDFs that are in the 100's of MB range. I don't mind adding the getInt64() stuff myself as that is easy to do without needing to understand the rest of the code. But the incremental hashing would best be done by the original developer of the patch. So at a a minimum if we can get the incremental hashing in then I can sort out the rest of the 64-bit support. -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to poppler in Ubuntu. https://bugs.launchpad.net/bugs/740506 Title: verify digital signatures To manage notifications about this bug go to: https://bugs.launchpad.net/evince/+bug/740506/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
