I went through the patch written by me and unfortunately I can not make
it so that it returns the same result as before. I've separated axes in
which it searches for immediate up/down/left/right neighbours, sorted
them and found the neighbours by single pass (+ number of possible
neighbour candidates in the other axis for given block, which should be
sqrt(n) in average case).

The difference is that the patch searches for right-down neighbour by looking 
at down neighbour of its right neighbour and at the right neighbour of its down 
neighbour. If they match then it selects it as the right-bottom neighbour.
Previous version just searched for the closest block which is to the right of 
the block and below the block (and looking at the code, the result could depend 
on order of the blocks in the searched array).

Modifying the patch so that it would return the same results as without it 
would cost the whole efficiency.
Anyway, the efficiency improvement of my patch is not as big as the one from 
Brian so you can reject it (but I think that it improves the conversion :) ).

-- 
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to the bug report.
https://bugs.launchpad.net/bugs/33288

Title:
  Evince doesn't handle columns properly

To manage notifications about this bug go to:
https://bugs.launchpad.net/poppler/+bug/33288/+subscriptions

-- 
desktop-bugs mailing list
[email protected]
https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
  • [Bug 33288] Albert Astals Cid
    • [Bug 33288] Marek Kašík

Reply via email to