** Description changed:

  SRU Justification:
  
  [ Impact ]
  
- network.js passes an incorrect variable type when attempting
- to connect to an enterprise AP from the quicksettings panel.
+ Users are not able to connect to WPA2 enterprise networks from the
+ quicksettings panel. Any attempts to click on such a network will result
+ in the panel disappearing with no authentication popup.
  
- Specifically, in upstream patch d6779f34, the switch
- to shell_app_activate_action() was made without
- also wrapping the action parameter in an av variant.
- This patch adjusts network.js to use the correct av
- variant type when attempting to connect to an
- enterprise AP from the quicksettings panel.
+ With this patch, which fixes an incorrectly passed data type, clicking
+ on an enterprise network via the quicksettings panel will bring up the
+ correct authentication details prompt.
  
  [ Test Plan ]
  
  1. Set up a WPA or WPA2 access point. (You do not actually need a RADIUS 
server to reproduce the issue, since it occurs simply when trying to load the 
credential popup.)
  2. On your test device, click the quick-settings menu, then expand the Wi-Fi 
AP list. Select your enterprise AP
  
  [ Fix ]
  
  Adjust the variable type in network.js to match what the gnome-settings
  panel and gnome-shell actually expect
  
  [ Where problems could occur ]
  
  There should be no regressions here, since prior to this patch,
  launchSettingsPanel() was passing an invalid variable type that was
  failing a broad gnome-shell assertion, halting the desired command from
  running.
  
  Other callers of launchSettingsPanel() may be impacted by this change
  (but I would actually suspect that they'd suffer from the same issue, so
  my patch may fix those cases as well if so)
  
  [ Other Info ]
  Upstream patch: 
https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/3834
  
  Impacts Noble, Plucky, Questing
  (Jammy's quicksettings menu uses a different view which this bug isn't 
applicable to.)

** Description changed:

  SRU Justification:
  
  [ Impact ]
  
  Users are not able to connect to WPA2 enterprise networks from the
  quicksettings panel. Any attempts to click on such a network will result
  in the panel disappearing with no authentication popup.
  
- With this patch, which fixes an incorrectly passed data type, clicking
- on an enterprise network via the quicksettings panel will bring up the
- correct authentication details prompt.
+ With this patch, clicking on an enterprise network via the quicksettings
+ panel will bring up the correct authentication details prompt.
  
  [ Test Plan ]
  
  1. Set up a WPA or WPA2 access point. (You do not actually need a RADIUS 
server to reproduce the issue, since it occurs simply when trying to load the 
credential popup.)
  2. On your test device, click the quick-settings menu, then expand the Wi-Fi 
AP list. Select your enterprise AP
  
  [ Fix ]
  
  Adjust the variable type in network.js to match what the gnome-settings
  panel and gnome-shell actually expect
  
  [ Where problems could occur ]
  
  There should be no regressions here, since prior to this patch,
  launchSettingsPanel() was passing an invalid variable type that was
  failing a broad gnome-shell assertion, halting the desired command from
  running.
  
  Other callers of launchSettingsPanel() may be impacted by this change
  (but I would actually suspect that they'd suffer from the same issue, so
  my patch may fix those cases as well if so)
  
  [ Other Info ]
  Upstream patch: 
https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/3834
  
  Impacts Noble, Plucky, Questing
  (Jammy's quicksettings menu uses a different view which this bug isn't 
applicable to.)

-- 
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to gnome-shell in Ubuntu.
https://bugs.launchpad.net/bugs/2120331

Title:
  [SRU] status/network: Fix connecting to WPA[2] Enterprise networks
  from quicksettings panel

To manage notifications about this bug go to:
https://bugs.launchpad.net/gnome-shell/+bug/2120331/+subscriptions


-- 
desktop-bugs mailing list
[email protected]
https://lists.ubuntu.com/mailman/listinfo/desktop-bugs

Reply via email to