Our accessibility QA guys have tested these changes and find that they do not impact the accessibility of gnome-terminal.
My reading of the vte code was that these signals were being emitted too often. The signal will now be emitted once for every time vte_terminal_process_incoming rather than at least twice per character. Padraig On Thu, 2005-11-24 at 10:15 -0600, Federico Mena Quintero wrote: > On Thu, 2005-11-24 at 09:32 +0000, John Rice wrote: > > Great stuff Padraig - down from +500% to 6% degradation when cat'ing a > > large file sounds pretty good to me :) > > > > Anyone any idea of the effect of not flushing the pending events? > > Would it cause problems when typing quickly in the terminal? Problems > > in asian locales? > > The patch removes the "emit those signals" bit. > > I don't know how vte works internally, but it would be good to research > these: > > - Does proper a11y depend on those signals? > > - If it does, then how often do those signals really get emitted? Once > per character? What happens when you do "ls -l" - does a screen reader > read out everything to you? > > - Can the a11y implementation for vte throttle those signals, and not > re-fetch the contents unless the signal has not been emitted for N > milliseconds? Think of the "ls -l" case above. > > Federico > > _______________________________________________ > Gnome-accessibility-devel mailing list > Gnome-accessibility-devel@gnome.org > http://mail.gnome.org/mailman/listinfo/gnome-accessibility-devel _______________________________________________ desktop-devel-list mailing list desktop-devel-list@gnome.org http://mail.gnome.org/mailman/listinfo/desktop-devel-list
