On Thu, Mar 11, 2010 at 3:00 PM, Frederic Crozat <[email protected]>wrote:
> Le 11/03/2010 14:50, Gustavo Carneiro a écrit : > >> >> >> On Wed, Mar 10, 2010 at 6:05 PM, Frederic Crozat <[email protected] >> <mailto:[email protected]>> wrote: >> >> Le 12/01/2010 18:50, Frederic Crozat a écrit : >> >> Hi everyone, >> >> just a quick reminder about deprecation flags and tarball release : >> please avoid at all cost to hardcode deprecation flags in >> compilation >> flags, when a module is built from a tarball (it is ok to have such >> flags when building from gi checkout). >> >> Why, you may ask ? >> >> Well, I'm currently strugling with smoketesting GNOME 2.29.5 >> release and >> there are some tarballs no longer building because new G_SEAL >> deprecation were added in yesterday GTK+ 2.19.3 release and some >> modules >> were not fixed for this. >> >> Current guilty modules : >> - vte (bedhad is cooking a new release) >> - gnome-utils >> >> In a similar idea, try to avoid releasing tarballs which depends on >> other unreleased tarball module version. >> >> >> Since I'm the release team member taking care of 2.29.92 release, >> I'm going to rant again against modules which are hardcoding >> deprecation flags in their configure.in <http://configure.in> (or >> >> Makefile.am), even when building from tarballs. Please, avoid that, >> it is killing us, since many released modules are not building with >> latest gtk+ 2.19.7 (new deprecated added). If you want to use >> deprecation flags, check in configure.in <http://configure.in> if >> >> you are in a git checkout and enable them in that case, but do not >> enable them by default in tarballs. >> >> Current guilty modules, which needs a new release NOW (this is >> blocking GNOME 2.29.92 release): >> -gnome-python-desktop (doesn't build with latest totem-pl-parser, it >> seems) >> >> >> I am not aware of gnome-python-desktop 2.29.1 failing to build with >> newest totem-pl-parser. Just tried jhbuilding both, it works fine. >> > > Unfortunately, the totem CFLAGS doesn't contains gtk include headers, so it > breaks when building plparser.c : > > plparser.override:8:21: error: gtk/gtk.h: No such file or directory > > configure.ac : > PKG_CHECK_MODULES(TOTEM_PLPARSER, [totem-plparser >= > totem_required_version pygtk-2.0 >= pygtk_required_version], > > should be : > > PKG_CHECK_MODULES(TOTEM_PLPARSER, [totem-plparser >= > totem_required_version pygtk-2.0 >= pygtk_required_version gtk+-2.0 ], > > You are right that it does not build. I was convinced that 2.29.1 had the latest code in git, but I was mistaken. I just released 2.29.92 which should fix that build problem. Sorry for the delay. > (sorry for not opening a bug report, I thought it was related to > deprecation) > -- > Frederic Crozat > Mandriva > -- Gustavo J. A. M. Carneiro INESC Porto, UTM, WiN, http://win.inescporto.pt/gjc "The universe is always one step beyond logic." -- Frank Herbert
_______________________________________________ desktop-devel-list mailing list [email protected] http://mail.gnome.org/mailman/listinfo/desktop-devel-list
