Michael Catanzaro <[email protected]> wrote: ... > I'm about halfway done reading. I have a few suggestions, all minor: > > * The Visual Layout page discusses how many pixels to use as margins. > This is easy for developers to use, but it caused some confusion on LWN > given that on hidpi displays twice as many pixels will be used. Maybe > this should be clarified.
I'm a bit reluctant to do that. The guidelines don't generally comment on technical details. > * On the Dialogs page: "In particular, it is currently not recommended > to make the Close button the default in an instant apply window, as this > can lead to users closing the window accidentally before they have > finished using it." I think you can remove the word "currently," unless > you're planning to change your mind. :) Fixed. > * Regarding the keybindings page: Ctrl+Alt+Delete is power off, not log > off, and it is not disabled default, although it shows up in g-c-c as > log off. [1] Fixed. > * Throughout the HIG, you're mostly consistent in using ' and " instead > of the ’ and “ characters that are mandated by the Typography page. Some > search and replace might be appropriate here, to set a good example. :) Indeed! Fixed. > * On the index page: "If you have never read the Human Interface > Guidelines before, it is recommended that you start with the essentials > section, in particular the design principles page, before continuing to > learn about the design patterns." But this text is in the description > for the Interface elements section, not the Patterns section. Missing markup to break the paragraph - fixed. Excellent catches, Michael. Thanks so much. Allan _______________________________________________ desktop-devel-list mailing list [email protected] https://mail.gnome.org/mailman/listinfo/desktop-devel-list
