On Fri, Sep 19, 2014 at 11:45 PM, Alberts Muktupāvels < [email protected]> wrote:
> > On Fri, Sep 19, 2014 at 11:04 PM, Owen Taylor <[email protected]> wrote: > >> On Fri, 2014-09-19 at 22:49 +0300, Alberts Muktupāvels wrote: >> > On Fri, Sep 19, 2014 at 10:27 PM, Owen Taylor <[email protected]> >> > wrote: >> > On Fri, 2014-09-19 at 20:26 +0300, Alberts Muktupāvels wrote: >> > >> > > question to gnome-session and gnome-shell developers about >> > End Session >> > > dialog. >> > > >> > > >> > > Currently gnome-session expect that End Session Dialog is >> > available on >> > > org.gnome.Shell. Can we change it so it does not require >> > > org.gnome.Shell for that dialog? >> > >> > What's your reasoning for why you want this to be done? >> > >> > I am trying to keep alive old classic / fallback session now known as >> > Flashback session (metacity, gnome-panel). To show End Session Dialog >> > we need to connect to org.gnome.Shell. That works, but now >> > applications thinks that GNOME Shell is running... >> >> This is tricky - GNOME Shell is a system component of GNOME, and >> dependencies on it aren't limited to gnome-session - I also, for >> example, see uses of GNOME SHell D-Bus interfaces in >> gnome-control-center and gnome-settings-daemon. >> > > I am right now running Flashback session without GNOME Shell. > gnome-settings-daemon and gnome-control-center works without it. So at > least for now I don't see problem here. > > (Do global keybindings work without GNOME Shell running? I thought they >> relied on GNOME Shell for that for now.) >> > > Probably not, but that is other problem that I will have to deal with. > > >> My opinion is that the Fllashback cannot increase the maintenance load >> of GNOME ... there's a reason we wanted to get rid of fallback mode. >> > > It is not my intention. I attached example.patch for gnome-session. Then > we need patch for gnome-shell to export EndSessionDialog interface on > org.gnome.SessionManager.EndSessionDialog not on org.gnome.Shell. It does > not look like it would increase the maintenance load, but would allow > Flashback session to show that dialog without using org.gnome.Shell. > And it looks like patch for gnome-shell will be even simpler. Only one extra line, see attachment. Now with patched gnome-session and gnome-shell end session dialog works fine in GNOME Shell and GNOME Flashback sessions. Should I create properly formatted patches and bug reports? It would be nice if this could be included when 3.16 development starts. -- Alberts Muktupāvels
From 49b7938aa310dccb303a8f9600dcd5bb9c601562 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Alberts=20Muktup=C4=81vels?= <[email protected]> Date: Sat, 20 Sep 2014 00:40:03 +0300 Subject: [PATCH] example 2 --- js/ui/endSessionDialog.js | 2 ++ 1 file changed, 2 insertions(+) diff --git a/js/ui/endSessionDialog.js b/js/ui/endSessionDialog.js index 966bae2..de7084c 100644 --- a/js/ui/endSessionDialog.js +++ b/js/ui/endSessionDialog.js @@ -373,6 +373,8 @@ const EndSessionDialog = new Lang.Class({ this._dbusImpl = Gio.DBusExportedObject.wrapJSObject(EndSessionDialogIface, this); this._dbusImpl.export(Gio.DBus.session, '/org/gnome/SessionManager/EndSessionDialog'); + + Gio.DBus.session.own_name('org.gnome.SessionManager.EndSessionDialog', Gio.BusNameOwnerFlags.REPLACE, null, null); }, _onDestroy: function() { -- 2.1.0
_______________________________________________ desktop-devel-list mailing list [email protected] https://mail.gnome.org/mailman/listinfo/desktop-devel-list
