If we keep the mirrors around, then we should at the very least ensure that pull requests aren't able to be opened at all on the repos. In general though, I would be in favor of getting rid of the mirror because it can cause frustration or confusion on the part of new contributors. This is showcased with the two examples in Michael's issue report.

Regards,
Chris

On Sun, Feb 3, 2019 at 9:54 PM, Jan Tojnar via desktop-devel-list <desktop-devel-list@gnome.org> wrote:
In my opinion, GitHub is still superior for viewing code:

1. It is much faster. Code loads with the page instead of having to wait for AJAX request.

2. GitHub offers a feature to jump to blame from parent commit of the change: https://gitlab.com/gitlab-org/gitlab-ce/issues/30749

3. GitLab does not support any references from gitrevisions(7) other than commit hash, compare https://github.com/GNOME/gnome-shell/commit/af34b7c25e39e727f7dbd6e3dae0e7c5fe60f141%5E and https://gitlab.gnome.org/GNOME/gnome-shell/commit/af34b7c25e39e727f7dbd6e3dae0e7c5fe60f141%5E

Until these are addressed, we should keep GitHub.

On Po, úno 4, 2019 at 2:40 AM, Michael Gratton <m...@vee.net> wrote:
Hi all,

While the GitHub mirror may have been useful back before GitLab, it actually discourages contributions because PRs aren't accepted there. I've not seen from any positive outcomes from it that I can remember, only negative ones. As such I think it should be deleted.

Because of this I just filed: https://gitlab.gnome.org/Infrastructure/Infrastructure/issues/86​ – any thoughts?

//Mike



_______________________________________________
desktop-devel-list mailing list
desktop-devel-list@gnome.org
https://mail.gnome.org/mailman/listinfo/desktop-devel-list

_______________________________________________
desktop-devel-list mailing list
desktop-devel-list@gnome.org
https://mail.gnome.org/mailman/listinfo/desktop-devel-list
_______________________________________________
desktop-devel-list mailing list
desktop-devel-list@gnome.org
https://mail.gnome.org/mailman/listinfo/desktop-devel-list

Reply via email to