Hi Patrick, On Sat, 2007-12-15 at 22:37 +0100, Patrick Ale wrote: > I made a change to SUNWsolaris-devel-doc.spec. Originally it > references to %define tarball_version 0.10. However, only 0.2 and 0.5 > are available from the sdlc website. > > So, this spec file downloads version 0.5, and makes it compile happy. > (spec attached).
This is our fault, those tarballs should have been uploaded to DLC. I'll upload them tomorrow. > Also I attach a modified spec file for firefox.spec. > This is regarding the apoc-adapter where the source isn't available > for, to the general public. > This means the build will file by default, since the default is to > compile --with-apoc-adapter. > > I googled a bit and saw a post from Alvaro Lopez mentioning the > default behavior should be changed to --without-apoc-adapter. > The URL is: > http://mail.opensolaris.org/pipermail/jds-review/2007-March/001489.html > > Apparently that patch didn't get commited or is forgotten in later > versions. > I modified the spec file so the default is --without-apoc-adapter. Yes, the default should be --without-apoc-adapter. Ideally, this should an option defined in include/options.inc and called %option_with_apoc_adapter / %option_without_apoc_adapter > Of course you can ditch the specs all together and ignore it. No, your feedback is most welcome. But please send svn diffs instead of full spec files, and jds-review at opensolaris.org is a better list to send diffs to. If the diff looks good, we can just tell you to commit (: See http://opensolaris.org/os/project/jds/documents/code_review/ and http://opensolaris.org/os/project/jds/documents/requesting_svn_account/ Thanks, Laca
