If someone would like a reason to do a commit...
55 of our patches do not apply perfectly, 'patch' ignores a few of the context 
lines when applying the patch. For the most part this doesn't break the patch 
but we don't know.
Builds using the new version of the CBE (1.5) will break in such situations 
(this is intentional).

Attached is a list of the patches that need to be reworked for the current 
source tarballs.
An example fro the attached file:
  Log: SUNWfirefox.log:
    firefox-05-preload.diff:
      browser/app/mozilla.in: Hunk 1(fuzz 1).
This means that firefox-05-preload.diff patches browser/app/mozilla.in. So the 
portions of firefox-05-preload.diff that refer to browser/app/mozilla.in need 
to be regenerated.
Each engineer has a different method for doing this.
I expand the source tarball, backup the mozilla.in (cp to mozilla.in.orig).
While viewing firefox-05-preload.diff I update mozilla.in.
Then, 'diff -u mozilla.in.orig mozilla.in' and put this output into 
firefox-05-preload.diff.
Then email the updated patch jds-code-review at opensolaris dot org.
 
 
This message posted from opensolaris.org

Reply via email to