Launchpad has imported 12 comments from the remote bug at
https://bugs.freedesktop.org/show_bug.cgi?id=40020.

If you reply to an imported comment from within Launchpad, your comment
will be sent to the remote bug automatically. Read more about
Launchpad's inter-bugtracker facilities at
https://help.launchpad.net/InterBugTracking.

------------------------------------------------------------------------
On 2011-08-11T16:33:47+00:00 Michael Terry wrote:

Hello!  I've working on adding support to accountsservice for LightDM,
which Ubuntu is switching to starting with Ubuntu 11.10.

Currently, accountsservice assumes GDM is in use.  (It matters only for
saving and loading autologin settings.)

This patch will do two things:
 1) When saving autologin settings, try to write to both GDM and LightDM config 
files, if they are available.

 2) When loading autologin settings, try to determine which of GDM and
LightDM are running and load from its respective config file.

Reply at:
https://bugs.launchpad.net/accountsservice/+bug/798962/comments/12

------------------------------------------------------------------------
On 2011-08-11T16:43:24+00:00 Rstrode wrote:

That's probably okay.

Maybe a better approach, though, would be to get away from DM specific
code and make accounts service manage its own configuration that the DMs
use instead of their own configuration.

thoughts?

Reply at:
https://bugs.launchpad.net/accountsservice/+bug/798962/comments/13

------------------------------------------------------------------------
On 2011-08-11T16:43:30+00:00 Michael Terry wrote:

Created attachment 50137
Proposed patch

One notable thing about this patch is how it checks whether GDM is
running.  It currently checks if org.gnome.DisplayManager is owned.  Is
there a better way?

Reply at:
https://bugs.launchpad.net/accountsservice/+bug/798962/comments/14

------------------------------------------------------------------------
On 2011-08-11T16:48:16+00:00 Rstrode wrote:

(In reply to comment #2)
> Created an attachment (id=50137) [details]
> Proposed patch
> 
> One notable thing about this patch is how it checks whether GDM is running.  
> It
> currently checks if org.gnome.DisplayManager is owned.  Is there a better way?

org.gnome.DisplayManager seems reasonable to me.

Other than that, are you happy with your patch?

Reply at:
https://bugs.launchpad.net/accountsservice/+bug/798962/comments/15

------------------------------------------------------------------------
On 2011-08-11T16:52:59+00:00 Michael Terry wrote:

As for the patch, I have done some quick tests and it seems to work for
me.  I'll likely play with it another day or so and make sure I don't
hit any issues.  So if you want to hold off until I give a more
resounding vote of QA confidence, that's reasonable.

As for config files, I'm fine with either way (accountsservice tweaking
others' files or having its own), but I'm not a main LightDM or GDM
developer so can't really speak to how easy a central config file would
be to adopt.

This is just one config value (autologin user).  If that's all that's
envisioned, I'm not sure it's worth having a special config file.  But
if you plan to add more display manager settings to accountsservice,
maybe it starts to make sense.

Reply at:
https://bugs.launchpad.net/accountsservice/+bug/798962/comments/16

------------------------------------------------------------------------
On 2011-08-11T16:55:36+00:00 Rstrode wrote:

alright, let's go with this approach for now, but reconsider if we end
up moving more options (like include/exclude lists?) or gain interest
from other DMs

Reply at:
https://bugs.launchpad.net/accountsservice/+bug/798962/comments/17

------------------------------------------------------------------------
On 2011-08-15T12:12:23+00:00 Matthias Clasen wrote:

Fwiw, I've always considered the current 'gdm support' a hack that
should go away when gdm starts talking to accountsservice. It makes a
lot more sense for the accountsservice to store this information itself,
and for interested DMs to query it.

Reply at:
https://bugs.launchpad.net/accountsservice/+bug/798962/comments/26

------------------------------------------------------------------------
On 2011-08-18T01:22:42+00:00 Robert Ancell wrote:

Hi,

As the LightDM maintainer I very much support the idea of having LightDM
reading configuration from the accounts service.

I am currently gauging interest on if other desktops will adopt AccountsService:
http://lists.freedesktop.org/archives/lightdm/2011-August/000051.html

Reply at:
https://bugs.launchpad.net/accountsservice/+bug/798962/comments/27

------------------------------------------------------------------------
On 2011-09-09T11:06:45+00:00 Martin Pitt wrote:

Mike, the patch doesn't apply any more to 0.6.14. Do you mind porting
it? Are you happy with how well it works?

Reply at:
https://bugs.launchpad.net/accountsservice/+bug/798962/comments/29

------------------------------------------------------------------------
On 2011-09-09T15:17:30+00:00 Michael Terry wrote:

Created attachment 51002
Patch #2

Here's an updated patch for 0.6.14 (and it fixes a bug with detecting
LightDM's autologin status).  Works for me now.

Reply at:
https://bugs.launchpad.net/accountsservice/+bug/798962/comments/30

------------------------------------------------------------------------
On 2011-10-17T19:50:33+00:00 Matthias Clasen wrote:

Comment on attachment 51002
Patch #2

Review of attachment 51002:
-----------------------------------------------------------------

::: src/daemon.c
@@ +1446,5 @@
> +{
> +        if (!save_autologin_gdm (daemon, name, enabled, error))
> +                return FALSE;
> +        if (!save_autologin_lightdm (daemon, name, enabled, error))
> +                return FALSE;

Hmm, I feel like this should always try both save functions, if we don't
want to look for which dm is actually in use.

ie it should be something like

result = TRUE;
result &= save_autologin_gdm(...);
result &= save_autologin_lightdm(...);
return result;

Reply at:
https://bugs.launchpad.net/accountsservice/+bug/798962/comments/32

------------------------------------------------------------------------
On 2012-04-30T09:26:23+00:00 Alessio Treglia wrote:

Hi all!

Any news on this?

Reply at:
https://bugs.launchpad.net/accountsservice/+bug/798962/comments/33

-- 
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to lightdm in Ubuntu.
https://bugs.launchpad.net/bugs/798962

Title:
  g-c-c "automatic login" settings not working with lightdm

Status in D-Bus interfaces for querying and manipulating user account 
information:
  Confirmed
Status in “accountsservice” package in Ubuntu:
  Fix Released
Status in “lightdm” package in Ubuntu:
  Invalid
Status in “accountsservice” source package in Oneiric:
  Fix Released
Status in “lightdm” source package in Oneiric:
  Invalid

Bug description:
  Binary package hint: gnome-control-center

  sytem, user accounts, select user, unlock, enter sudo pw, change
  "Automatic Login" to Yes, close window.  drill into it,  "Automatic
  Login" is No.  Set to yes again, reboot, not logged in.

  ProblemType: Bug
  DistroRelease: Ubuntu 11.10
  Package: gnome-control-center 1:3.0.2-1ubuntu4
  ProcVersionSignature: Ubuntu 3.0-1.2-generic 3.0.0-rc3
  Uname: Linux 3.0-1-generic x86_64
  Architecture: amd64
  Date: Fri Jun 17 16:01:44 2011
  ExecutablePath: /usr/bin/gnome-control-center
  ProcEnviron:
   SHELL=/bin/bash
   PATH=(custom, user)
   LANGUAGE=en_US:
   LANG=en_US
  SourcePackage: gnome-control-center
  UpgradeStatus: No upgrade log present (probably fresh install)

To manage notifications about this bug go to:
https://bugs.launchpad.net/accountsservice/+bug/798962/+subscriptions

-- 
Mailing list: https://launchpad.net/~desktop-packages
Post to     : [email protected]
Unsubscribe : https://launchpad.net/~desktop-packages
More help   : https://help.launchpad.net/ListHelp

Reply via email to