Excerpts from Sebastien Bacher's message of 2012-05-31 08:54:24 UTC: > Clint, on the diff when filtering out "noise": > > $ debdiff --exclude *win32* --exclude tests* --exclude Makefile.in --exclude > po --exclude docs --exclude ChangeLog --exclude configure --exclude > *generated* glib2.0_2.32.1-0ubuntu2.dsc glib2.0_2.32.3-0ubuntu1.dsc | diffstat > ... > INSTALL | 4 > NEWS | 75 > README | 2 > configure.ac | 16 > debian/changelog | 12 > debian/control | 2 > debian/control.in | 2 > debian/patches/git_powerpc_gresources.patch | 28 > debian/patches/gnetworkmonitor_dont_leak_networks.patch | 21 > debian/patches/series | 2 > gio/Makefile.am | 25 > gio/dbus-daemon.xml | 76 > gio/gapplication.c | 57 > gio/gapplicationimpl-dbus.c | 6 > gio/gconverterinputstream.c | 12 > gio/gdbus-2.0/codegen/config.py | 2 > gio/gdbus-2.0/codegen/utils.py | 7 > gio/gdbusaddress.c | 306 ++ > gio/gdbusdaemon.c | 1752 > ++++++++++++++++ > gio/gdbusdaemon.h | 19 > gio/gdbusprivate.c | 42 > gio/gdbusserver.c | 5 > gio/gdesktopappinfo.c | 3 > gio/gio.rc | 8 > gio/gioenums.h | 9 > gio/giomodule-priv.h | 4 > gio/giomodule.c | 6 > gio/gproxyaddressenumerator.c | 95 > gio/gresource.c | 5 > gio/gresourcefile.c | 1 > gio/gsocketcontrolmessage.c | 11 > glib/glib.rc | 8 > glib/gmain.c | 35 > glib/gutils.h | 2 > gmodule/gmodule.rc | 8 > gobject/gobject.h | 4 > gobject/gobject.rc | 8 > gthread/gthread.rc | 8 > 38 files changed, 2543 insertions(+), 145 deletions(-) > > so the diff is around 2690 lines, 1771 of those being the gdbusdaemon > for win32 use, it means the remaining diff is around 900 lines of actual > changes, it's not trivial but far from the 34k you listed >
Agreed. Thanks for giving me some help in isolating the changes. This is still inappropriate as an SRU. The policy is pretty clear, bugs that can be fixed in SRU are: * Severe regressions * loss of user data * Bugs which do not fit under above categories, but (1) have an obviously safe patch and (2) affect an application rather than critical infrastructure packages (like X.org or the kernel) * New hardware * New commercial software * FTBFS Policy allows micro releases if *all* of the changes match this criteria. While the changes you filtered out are not relevant, none of them meet this policy. So, I can't really ignore all of those things that you filtered out. I know that some other micro-releases that skirt this policy have been accepted, but they matched the third criteria above. glib is critical infrastructure, so I have to keep that in mind. The reason for the policy isn't to be annoying. Its to preserve the SRU team's time and make sure we are reviewing *EVERY* change that goes into the stable release. An appropriate SRU would just add the patch: gnetworkmonitor_dont_leak_networks.patch. Rejecting upload, please re-upload as a patch, not a new upstream release. -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to glib2.0 in Ubuntu. https://bugs.launchpad.net/bugs/998521 Title: whoopsie process is leaking memory Status in Whoopsie Daisy: Fix Released Status in “glib2.0” package in Ubuntu: Fix Committed Status in “whoopsie-daisy” package in Ubuntu: Confirmed Status in “glib2.0” source package in Precise: Fix Committed Status in “whoopsie-daisy” source package in Precise: Confirmed Status in “glib2.0” source package in Quantal: Fix Committed Status in “whoopsie-daisy” source package in Quantal: Confirmed Bug description: Impact: stable update from the upstream serie including a fix for a leak affecting the default Ubuntu bug reporting tool (whoopsie) Development Fix: the fix is in upstream glib git and will be in q with the next update Stable Fix: the fix is a one liner, the new version has some extra changes Test Case: watch the whoopsie memory usage over time, it should be stable Regression Potential: it's glib, the update should be carefully tested I have a 12.04 server running for 7 days and today I noticed some things started to be swapped out. top shows: PID USER PR NI VIRT RES SHR S %CPU %MEM TIME+ COMMAND 1975 whoopsie 20 0 2649m 1.4g 484 S 0 18.5 14:05.67 whoopsie with 1.4g residential memory. There were 2 crashed applications, facter with .crash file is 2.8Mb and landscape-sysinfo of 17K so it does not look like it is related. I will keep the process running in case i can provide more information and will monitor the process to see whether it is leaking memory. ProblemType: Bug DistroRelease: Ubuntu 12.04 Package: whoopsie 0.1.32 ProcVersionSignature: Ubuntu 3.2.0-24.37-generic 3.2.14 Uname: Linux 3.2.0-24-generic x86_64 ApportVersion: 2.0.1-0ubuntu7 Architecture: amd64 CrashReports: 640:0:111:17379:2012-05-05 10:59:39.677061820 +0300:2012-05-05 10:59:39.673061820 +0300:/var/crash/_usr_bin_landscape-sysinfo.0.crash 640:0:111:2838166:2012-05-07 00:54:24.435092602 +0300:2012-05-07 00:54:19.759092709 +0300:/var/crash/_usr_bin_facter.0.crash Date: Sat May 12 21:41:18 2012 InstallationMedia: Ubuntu-Server 12.04 LTS "Precise Pangolin" - Release amd64 (20120424.1) SourcePackage: whoopsie-daisy UpgradeStatus: No upgrade log present (probably fresh install) To manage notifications about this bug go to: https://bugs.launchpad.net/whoopsie-daisy/+bug/998521/+subscriptions -- Mailing list: https://launchpad.net/~desktop-packages Post to : [email protected] Unsubscribe : https://launchpad.net/~desktop-packages More help : https://help.launchpad.net/ListHelp
