(In reply to Chris Coulson from comment #14) > Created attachment 602368 > Treat distribution/searchplugins as a known location and don't use the full > path for the search engine ID's > > We've been carrying a distro patch for a long time to do the normalize() in > _loadEnginesFromDir(), and I'd like to be able to drop this at some point. > Whilst normalize() works for us, it probably wouldn't work in all cases (ie, > if the application directory can move around and nobody symlinked the > distribution folder to a stable path). > > Would you accept something like the attached patch (which basically treats > distribution/searchplugins as a known location)?
Interestingly, I have a somehow similar patch in debian, but i treat distribution/searchplugins as [app]/ instead of [distribution]/, because i moved all the default searchplugins there. And I have some additional code to make the transition smoother, although there are apparently some edge cases where that doesn't work quite well. -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to firefox in Ubuntu. https://bugs.launchpad.net/bugs/428306 Title: default search engines are removed and readded (keywords wiped) with upgrade Status in The Mozilla Firefox Browser: Confirmed Status in “firefox” package in Ubuntu: Fix Released Bug description: Binary package hint: firefox-3.5 I updated Karmic, which included upgrading Firefox from 3.5.2 to 3.5.3. I previously had the keyword 'w' set for the Wikipedia search. It appears that all the default search engines have been removed and added again to the bottom of the list of search engines, without keywords. This means I've had to add back keywords for default search engines I use, and remove all the default search engines I had previously removed (eg. amazon, ebay, etc). The same situation occurs when upgrading from firefox-3.0 to firefox-3.5. Steps to reproduce: 0) Install both firefox-3.0 and firefox-3.5. Move away ~/.mozilla so that you start with a fresh profile. 1) Run firefox-3.0. In 'Manage Search Engines', add keywords to some, and remove others. Close firefox-3.0. 2) Run firefox-3.5. Check 'Manage Search Engines'. What should happen: Search engines are the same as they were with firefox-3.0 What actually happens: Default search engines have keywords wiped, and previously removed search engines have been added again. To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/428306/+subscriptions -- Mailing list: https://launchpad.net/~desktop-packages Post to : [email protected] Unsubscribe : https://launchpad.net/~desktop-packages More help : https://help.launchpad.net/ListHelp
