** Bug watch added: GNOME Bug Tracker #685041
   https://bugzilla.gnome.org/show_bug.cgi?id=685041

** Also affects: vinagre via
   https://bugzilla.gnome.org/show_bug.cgi?id=685041
   Importance: Unknown
       Status: Unknown

-- 
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to vinagre in Ubuntu.
https://bugs.launchpad.net/bugs/1071055

Title:
  vinagre crashed on connecting to vnc

Status in Vinagre: VNC client for GNOME:
  Unknown
Status in “vinagre” package in Ubuntu:
  Confirmed

Bug description:
  on ubuntu  12.10
  ii  vinagre                       3.6.0-0ubuntu1      amd64               
remote desktop client for the GNOME Desktop

  when connecting to vnc which requires password authentication
  vinagre will crash
  this is because the usernaem inside the 
vinagre_tab_find_credentials_in_keyring function will be null

  The following patch will resolve it

  diff --git a/plugins/vnc/vinagre-vnc-tab.c b/plugins/vnc/vinagre-vnc-tab.c
  index 10bed13..d591a29 100644
  --- a/plugins/vnc/vinagre-vnc-tab.c
  +++ b/plugins/vnc/vinagre-vnc-tab.c
  @@ -492,7 +492,10 @@ vnc_authentication_cb (VncDisplay *vnc, GValueArray 
*credList, VinagreVncTab *vn
   
     if (need_password || need_username)
       {
  -      vinagre_tab_find_credentials_in_keyring (tab, &username, &password);
  +      if (vinagre_connection_get_username (conn) != NULL)
  +        {
  +          vinagre_tab_find_credentials_in_keyring (tab, &username, 
&password);
  +        }
         if ( (need_username && !username) || (need_password && !password) )
        {
          host = vinagre_connection_get_best_name (conn);

To manage notifications about this bug go to:
https://bugs.launchpad.net/vinagre/+bug/1071055/+subscriptions

-- 
Mailing list: https://launchpad.net/~desktop-packages
Post to     : [email protected]
Unsubscribe : https://launchpad.net/~desktop-packages
More help   : https://help.launchpad.net/ListHelp

Reply via email to