On 11/05/2012 07:13 PM, Tanu Kaskinen wrote: > On Sun, 2012-11-04 at 23:09 +0100, David Henningsson wrote: >> On 11/04/2012 02:22 PM, Tanu Kaskinen wrote: >>> On Sat, 2012-11-03 at 19:51 +0100, David Henningsson wrote: >>>> Returning NULL seems to be the right thing to do here, even if >>>> gnome-control-center does not handle that very well IIRC. So we might >>>> need an additional patch in g-c-c. >>>> So assuming I commit a patch doing that. If somebody else wants to add >>>> logic to figure out how large the hole is, that could be discussed >>>> separately. >>>> Any objections? >>> >>> It's not clear what you meant by "add logic to figure out how large the >>> hole is". Add to where? pa_stream_peek() or gnome-control-center? >> >> I was referring to your earlier comment "An addition: the client >> probably wants to know how large the hole is.", i e pa_stream_peek. >> >>> To me, reporting the hole length in the "nbytes" parameter of >>> pa_stream_peek() seems like the right thing to do, so I hope your patch >>> will do this. >> >> It does not: I was just suggesting to discuss that separately. > > Ok. Well, I'm suggesting to not make these issues separate, since it's a > small thing to decide and implement, and doing a separate fix would be > "fixing a fix".
I don't have an issue with step-by-step improvements. I see this as such (if the second step is to be seen as an improvement). > Does someone have an issue with returning the hole size > in the nbytes argument? Not if you're volunteering to do the work. All I care about is that PA clients can crash for this reason, and I'd like that to stop happening. Note: gnome-control-center needs a corresponding fix either way, as it currently checks the length rather than the NULL pointer, IIRC. -- David Henningsson, Canonical Ltd. https://launchpad.net/~diwic -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to pulseaudio in Ubuntu. https://bugs.launchpad.net/bugs/1058200 Title: [sound]: gnome-control-center crashed with SIGABRT in pa_memblock_acquire() Status in “pulseaudio” package in Ubuntu: Fix Released Bug description: The Sound panel has been extremely crash-prone for the past oh, maybe 2 weeks. ProblemType: Crash DistroRelease: Ubuntu 12.10 Package: gnome-control-center 1:3.4.2-0ubuntu15 ProcVersionSignature: Ubuntu 3.5.0-15.23-generic 3.5.4 Uname: Linux 3.5.0-15-generic x86_64 ApportVersion: 2.5.2-0ubuntu4 Architecture: amd64 CrashCounter: 1 Date: Wed Sep 26 15:34:20 2012 ExecutablePath: /usr/bin/gnome-control-center ProcCmdline: gnome-control-center --overview Signal: 6 SourcePackage: gnome-control-center StacktraceTop: raise () from /lib/x86_64-linux-gnu/libc.so.6 abort () from /lib/x86_64-linux-gnu/libc.so.6 pa_memblock_acquire () from /usr/lib/x86_64-linux-gnu/pulseaudio/libpulsecommon-2.1.so pa_stream_peek () from /usr/lib/x86_64-linux-gnu/libpulse.so.0 ?? () from /usr/lib/control-center-1/panels/libsound.so Title: [sound]: gnome-control-center crashed with SIGABRT in raise() UpgradeStatus: No upgrade log present (probably fresh install) UserGroups: adm cdrom dip libvirtd lpadmin plugdev sambashare sbuild sudo usr_lib_gnome-control-center: activity-log-manager-control-center 0.9.4-0ubuntu3 deja-dup 23.92-0ubuntu1 gnome-control-center-signon 0.0.17-0ubuntu1 indicator-datetime 12.10.1-0ubuntu1 To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/pulseaudio/+bug/1058200/+subscriptions -- Mailing list: https://launchpad.net/~desktop-packages Post to : [email protected] Unsubscribe : https://launchpad.net/~desktop-packages More help : https://help.launchpad.net/ListHelp
