The attachment "0001-Improve-thread-safety-of-localization.patch" of
this bug report has been identified as being a patch.  The ubuntu-
reviewers team has been subscribed to the bug report so that they can
review the patch.  In the event that this is in fact not a patch you can
resolve this situation by removing the tag 'patch' from the bug report
and editing the attachment so that it is not flagged as a patch.
Additionally, if you are member of the ubuntu-reviewers team please also
unsubscribe the team from this bug report.

[This is an automated message performed by a Launchpad user owned by
Brian Murray.  Please contact him regarding any issues with the action
taken in this bug report.]

** Tags added: patch

-- 
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to libx11 in Ubuntu.
https://bugs.launchpad.net/bugs/1062534

Title:
  Thread unsafe access to internal linked list, breaks Origin games in
  Wine

Status in Modular X11 Libraries:
  Confirmed
Status in “libx11” package in Ubuntu:
  Confirmed

Bug description:
  In file src/xlibi18n/lcConv.c the following linked list head is
  defined

  static XlcConverterList conv_list = NULL;

  Which is then modified by _XlcSetConverter and get_converter in a non
  thread-safe manner. Inside get_converter the list is reorderder to
  increase the efficiency of looking up the same element the next time,
  but this is especially dangerous since a seemingly read-only method is
  actually modifying the data.

  Modifying the list in such thread unsafe manner does case the list to
  become garbled in some workloads and causes infinite loops when the
  get_converter is invoked. The solution I suggest is to add a mutex or
  spinlock around accesses to the linked list, I would it myself but I'm
  not sure about what is the usual mutex implementation for this
  project.

To manage notifications about this bug go to:
https://bugs.launchpad.net/xlibs/+bug/1062534/+subscriptions

-- 
Mailing list: https://launchpad.net/~desktop-packages
Post to     : [email protected]
Unsubscribe : https://launchpad.net/~desktop-packages
More help   : https://help.launchpad.net/ListHelp

Reply via email to