On 05/14/2013 11:46 AM, Tanu Kaskinen wrote:
> On Tue, 2013-05-14 at 10:31 +0200, David Henningsson wrote:
>> This bug [1] is still reported as present in 3.0, so I tried to track it
>> down, but I'm not sure what the best fix is. Here's where it crashes:
>>
>> module-stream-restore.c:
>> if (sink_input->save_volume &&
>> pa_sink_input_is_volume_readable(sink_input)) {
>> pa_assert(sink_input->volume_writable);
>>
>> According to this code, volume_writeable must be true if save_volume is
>> true. It apparently isn't always so.
>>
>> But what is the right solution?
>> 1) Ignore volume_writable, i e, just remove the assertion, or
>> 2) If volume_writable is false, skip saving the volume, but not mute
>> and route, or
>> 3) If volume_writable is false, skip saving the sink input completely
>>
>> Or, should one
>> 4) Change everywhere that sets save_volume to "true" to also check for
>> volume_writable and if so never set save_volume to true?
>>
>> I'm not sure what the thoughts are behind these two variables, so
>> looking for advice here.
>
> If volume_writable is false, it doesn't make sense to save the volume,
> because the volume should only be saved when the user sets the volume,
> but the user can't set the volume if it's not writable. So, I think 1 is
> not good. 2 is something that could be considered, but 3 is not. I would
> prefer 4 in some form, but it's bad if every place where save_volume is
> enabled needs to check volume_writable. I think
> pa_sink_input_set_save_volume() would make sense. The function would
> fail if saving the volume is not allowed. The callers could check if the
> function fails, but I don't think that would be necessary in most cases.
Save_volume was not set in very many places, so I believe the just sent
patch would suffice?
--
David Henningsson, Canonical Ltd.
https://launchpad.net/~diwic
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to pulseaudio in Ubuntu.
https://bugs.launchpad.net/bugs/896602
Title:
pulseaudio crashed with SIGABRT in subscribe_callback()
Status in “pulseaudio” package in Ubuntu:
In Progress
Bug description:
I see all the old bugs have a fix,,, well here it breaks again.
ProblemType: Crash
DistroRelease: Ubuntu 12.04
Package: pulseaudio 1:1.1-0ubuntu1
ProcVersionSignature: Ubuntu 3.2.0-1.3-generic 3.2.0-rc2
Uname: Linux 3.2.0-1-generic x86_64
NonfreeKernelModules: wl
AlsaVersion: Advanced Linux Sound Architecture Driver Version 1.0.24.
ApportVersion: 1.90-0ubuntu1
Architecture: amd64
ArecordDevices:
**** List of CAPTURE Hardware Devices ****
card 0: Intel [HDA Intel], device 0: CONEXANT Analog [CONEXANT Analog]
Subdevices: 1/1
Subdevice #0: subdevice #0
AudioDevicesInUse:
USER PID ACCESS COMMAND
/dev/snd/controlC0: siucdude 5677 F.... pulseaudio
/dev/snd/pcmC0D0p: siucdude 5677 F...m pulseaudio
Card0.Amixer.info:
Card hw:0 'Intel'/'HDA Intel at 0xf4700000 irq 47'
Mixer name : 'Conexant CX20561 (Hermosa)'
Components : 'HDA:14f15051,17aa3c2b,00100000'
Controls : 16
Simple ctrls : 8
CheckboxSubmission: 436b39225e95524b1259e913c38499a0
CheckboxSystem: 3e53d3ea5811723345f19eff5070f9ab
Date: Sat Nov 26 10:04:15 2011
ExecutablePath: /usr/bin/pulseaudio
InstallationMedia: Ubuntu 10.04 "Lucid Lynx" - Beta amd64 (20100318)
ProcCmdline: /usr/bin/pulseaudio --start --log-target=syslog
ProcEnviron:
PATH=(custom, no user)
LANG=en_US.UTF-8
SHELL=/bin/bash
Signal: 6
SourcePackage: pulseaudio
StacktraceTop:
?? () from /usr/lib/pulse-1.1/modules/module-stream-restore.so
?? () from /usr/lib/libpulsecore-1.1.so
pa_mainloop_dispatch () from /usr/lib/x86_64-linux-gnu/libpulse.so.0
pa_mainloop_iterate () from /usr/lib/x86_64-linux-gnu/libpulse.so.0
pa_mainloop_run () from /usr/lib/x86_64-linux-gnu/libpulse.so.0
Title: pulseaudio crashed with SIGABRT in pa_mainloop_dispatch()
UpgradeStatus: No upgrade log present (probably fresh install)
UserGroups: adm admin cdrom dialout libvirtd lpadmin plugdev sambashare
dmi.bios.date: 09/29/2009
dmi.bios.vendor: LENOVO
dmi.bios.version: 0CCN58WW(V1.24)
dmi.board.name: JIWA1
dmi.board.vendor: LENOVO
dmi.board.version: REFERENCE
dmi.chassis.asset.tag: No Asset Tag
dmi.chassis.type: 10
dmi.chassis.vendor: No Enclosure
dmi.chassis.version: N/A
dmi.modalias:
dmi:bvnLENOVO:bvr0CCN58WW(V1.24):bd09/29/2009:svnLENOVO:pn4151/200:pvrLenovo3000G530:rvnLENOVO:rnJIWA1:rvrREFERENCE:cvnNoEnclosure:ct10:cvrN/A:
dmi.product.name: 4151/200
dmi.product.version: Lenovo 3000 G530
dmi.sys.vendor: LENOVO
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/pulseaudio/+bug/896602/+subscriptions
--
Mailing list: https://launchpad.net/~desktop-packages
Post to : [email protected]
Unsubscribe : https://launchpad.net/~desktop-packages
More help : https://help.launchpad.net/ListHelp
