Urgh. Vala code is entirely unreviewable for SRUs. We, on the SRU team, should really work out what to do about that.
This seems like a reasonably risky change - from code that's sometimes unresponsive, to code that might crash in new and interesting ways! Also, it seems that a simpler change might be to simply delete the autosave file on clean shutdown? I've rejected this from the queue; could you please upload again, either with just the fixes for the other two bugs or with a less invasive fix for this bug? Or, I guess, convince me or another SRU team member that this is the most appropriate fix and we'll fish it out of the rejected queue. -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to simple-scan in Ubuntu. https://bugs.launchpad.net/bugs/1245678 Title: Simple Scan hangs repeatedly on Ubuntu 13.10 Status in “simple-scan” package in Ubuntu: Fix Released Status in “simple-scan” source package in Saucy: In Progress Status in “simple-scan” source package in Trusty: Fix Released Bug description: Simple Scan becomes highly unresponsive due to how it automatically saves documents as they are being scanned. This is due to writing large files into a sqlite database and doing it more frequently than is required. To reproduce: 1. Open Simple Scan 2. Scan a lot of pages Expected result: The pages scan quickly without excessive memory usage. Observed result: The UI is highly unresponsive and looking in ~/.cache/simple-scan/autosaves shows a very large database file that is being frequently updated. Regression potential: Medium. The autosave mechanism was rewritten to be more efficient. There may be new bugs exposed in its usage. To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/simple-scan/+bug/1245678/+subscriptions -- Mailing list: https://launchpad.net/~desktop-packages Post to : [email protected] Unsubscribe : https://launchpad.net/~desktop-packages More help : https://help.launchpad.net/ListHelp
