After talking with Chris the Vala code he is referring to being hard to review is the .c file changes, not the .vala changes. This is due to autotools (stupidly) distributing the .c files in the releases.
To be clear, the current code is not sometimes unresponsive, but severely unresponsive in all but the most trivial cases. This is due to the constant rewriting of image binary data (that may be huge) to a sqlite database (which is slow) on many unrelated document changes (e.g. moving the crop). Both the existing and new code deletes the autosave file on clean exit. Smaller changes were reviewed to the existing code but I judged them to be a higher risk than the new implementation. We could have the option to disable the autosave code for a simpler SRU, but this would be a feature regression. It is a useful feature since many SANE drivers can crash during a scan causing the user to loose all data. Note the new code is currently running in Ubuntu 14.04. -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to simple-scan in Ubuntu. https://bugs.launchpad.net/bugs/1245678 Title: MASTER: autosaves hang Simple Scan repeatedly on Ubuntu 13.10 Status in Simple Scan: Triaged Status in “simple-scan” package in Ubuntu: Fix Released Status in “simple-scan” source package in Saucy: In Progress Status in “simple-scan” source package in Trusty: Fix Released Bug description: THIS IS ACTUALLY FIXED IN UPSTREAM SIMPLE SCAN. BUT AS IT IS NOT FIXED IN UBUNTU 13.10 A LOT OF DUPLICATES ARE CREATED. IF THIS BUG IS MARKED FIXED IN SIMPLE SCAN, THIS BUG WILL DISAPPEAR FROM SEARCH RESULTS. THIS MAKES IT HARDER TO MARK DUPLICATES. PLEASE CLOSE THIS BUG ONLY WHEN "THE SITUATION" IS RESOLVED, EVEN IF THE ACTUAL BUG IS ALREADY SOLVED. ----- Simple Scan becomes highly unresponsive due to how it automatically saves documents as they are being scanned. This is due to writing large files into a sqlite database and doing it more frequently than is required. To reproduce: 1. Open Simple Scan 2. Scan a lot of pages Expected result: The pages scan quickly without excessive memory usage. Observed result: The UI is highly unresponsive and looking in ~/.cache/simple-scan/autosaves shows a very large database file that is being frequently updated. Regression potential: Medium. The autosave mechanism was rewritten to be more efficient. There may be new bugs exposed in its usage. To manage notifications about this bug go to: https://bugs.launchpad.net/simple-scan/+bug/1245678/+subscriptions -- Mailing list: https://launchpad.net/~desktop-packages Post to : [email protected] Unsubscribe : https://launchpad.net/~desktop-packages More help : https://help.launchpad.net/ListHelp
