OK, I just made that change

http://cgit.freedesktop.org/udisks/commit/?id=fcdd8f48b6ac9b1b6da82fdf5f59230fc2ea6feb

and tested it with a couple of different units. Notes

 - One of my devices (bus-powered) does not accept the START STOP UNIT
   command so we just continue if it fails. That is, this patch should
   not break existing behavior.

 - Another device (not bus-powered) used to spin down a couple of seconds
   after removing power to the USB port. With this patch it spins down
   immediately. (Which is actually nicer.)

 - Still works on USB sticks etc.

 - I didn't add SCSI SYNCHRONIZE CACHE as that command failed on all my
   devices. I also don't think it's necessary as the device drivers will
   issue something like this in part of the fsync(2) call that we do
   before this.

Please test if the patch works and report back - thanks!

-- 
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to gnome-disk-utility in Ubuntu.
https://bugs.launchpad.net/bugs/1239087

Title:
  Safely remove is not working (or broken) in Gnome Disks

Status in GNOME Disks:
  Fix Released
Status in abstraction for enumerating and managing block devices:
  Fix Released
Status in “gnome-disk-utility” package in Ubuntu:
  New
Status in “gnome-disk-utility” package in Fedora:
  Unknown
Status in “gnome-disk-utility” package in openSUSE:
  Confirmed

Bug description:
  In 12.04 I was able to safely remove USB-stick (make its LED off) and USB-HDD 
(do a spin down).
  In 13.04 this option is missed.

  In 13.10 it is appeared again, but not working as expected:
  +    Gnome Disks normally powers off the USB flash (tested on 4 different 
flashes and 2 USB cardreaders).
  -     Gnome Disks does not spin down USB HDD (but udisks --detach does)

  ProblemType: Bug
  DistroRelease: Ubuntu 13.10
  Package: gnome-disk-utility 3.8.2-1ubuntu2
  ProcVersionSignature: Ubuntu 3.10.0-1.8-generic 3.10.0-rc7
  Uname: Linux 3.10.0-1-generic i686
  NonfreeKernelModules: nvidia
  ApportVersion: 2.12.5-0ubuntu2
  Architecture: i386
  Date: Sat Oct 12 13:39:21 2013
  InstallationDate: Installed on 2013-03-06 (219 days ago)
  InstallationMedia: Ubuntu 13.04 "Raring Ringtail" - Alpha i386 (20130306)
  MarkForUpload: True
  SourcePackage: gnome-disk-utility
  UpgradeStatus: Upgraded to saucy on 2013-06-23 (110 days ago)

To manage notifications about this bug go to:
https://bugs.launchpad.net/gnome-disk-utility/+bug/1239087/+subscriptions

-- 
Mailing list: https://launchpad.net/~desktop-packages
Post to     : [email protected]
Unsubscribe : https://launchpad.net/~desktop-packages
More help   : https://help.launchpad.net/ListHelp

Reply via email to