Comment on attachment 8370331
WIP patch 2
Review of attachment 8370331:
-----------------------------------------------------------------
I'm OK with this approach. I'd like to see test cases for both a single
folder and a nested folder - for example:
make folder A
move A to trash
make new A
move A to trash
make new A
make new A/B
move A to trash
make sure trash has A and A-1 and A-2 and A-2/B
We don't need to test all those combinations for every message store
type, but we should at least test the copyFolder(...aNewName) parameter
works once on each store type.
::: mailnews/local/src/nsLocalMailFolder.cpp
@@ +1732,5 @@
> + while (1) {
> + rv = CheckIfFolderExists(newFolderNameUnderTrash, this, NULL);
> + if (rv == NS_MSG_FOLDER_EXISTS) {
> + newFolderNameUnderTrash.Assign(folderName);
> + newFolderNameUnderTrash.AppendLiteral("-"); // do we want this
> localizable? "<folder>-<SeqNo>"
I don't think this needs to be localizable.
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to thunderbird in Ubuntu.
https://bugs.launchpad.net/bugs/214366
Title:
Can't delete a folder if Trash already contains a folder of the same
name
Status in Mozilla Thunderbird Mail and News:
In Progress
Status in “thunderbird” package in Ubuntu:
Triaged
Bug description:
Binary package hint: mozilla-thunderbird
1. Create a new folder, eg. "Temp"
2. Delete it, OK
3. Create the same folder again
4. Delete it, OK
I expect it to be moved to my Trash folder, perhaps with a suffix
appended (it being the second instance of that folder in the trash).
Thunderbird popped up an error message. On an imap host:
The current command did not succeed. The mail server responded: Mailbox
already exists.
In the local folders:
A folder with that name already exists. Please enter a different name (!)
Workarounds:
1. Empty the trash
2. Rename the folder before deletion
3. Rename the folder already in the trash
4. Delete (permanently) the folder that is already in the trash
Ubuntu 7.10 Gutsy
thunderbird 2.0.0.12+nobinonly-0ubuntu0.7.10.0
To manage notifications about this bug go to:
https://bugs.launchpad.net/thunderbird/+bug/214366/+subscriptions
--
Mailing list: https://launchpad.net/~desktop-packages
Post to : desktop-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~desktop-packages
More help : https://help.launchpad.net/ListHelp
