(In reply to Ulf Zibis from comment #114)
> (In reply to Josiah Bruner [:JosiahOne] from comment #111)
> > No. The idea here is very similar to the common "priming read" concept
> > taught in introductory CS courses.
> In advanced CS practice I learned: No code duplicates, because if there
> comes a change along, one of the duplicates could be overseen.
Exactly.
>
> > newFolderName.Assign(folderName);
> > bool containsChild = true; // no need to preset it to true
> > int counter = 2; // yes, better than starting with 1 as before
But later below the loop I check whether i (counter) > 1 so the variable
exists outside the loop and value of 1 is also significant to the code.
So what about this:
uint32_t i;
for (i=1;;i++)) {
newFolderName.Assign(folderName);
if (i>1) {
newFolderName.AppendLiteral("(");
newFolderName.AppendInt(i);
newFolderName.AppendLiteral(")");
}
rv = ContainsChildNamed(newFolderName, &containsChild);
NS_ENSURE_SUCCESS(rv, rv);
if (!containsChild)
break;
}
Of course, instead of (i>1) test later on we could do
!newFolderName.Equals(folderName) but that is probably much more
expensive.
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to thunderbird in Ubuntu.
https://bugs.launchpad.net/bugs/214366
Title:
Can't delete a folder if Trash already contains a folder of the same
name
Status in Mozilla Thunderbird Mail and News:
In Progress
Status in “thunderbird” package in Ubuntu:
Triaged
Bug description:
Binary package hint: mozilla-thunderbird
1. Create a new folder, eg. "Temp"
2. Delete it, OK
3. Create the same folder again
4. Delete it, OK
I expect it to be moved to my Trash folder, perhaps with a suffix
appended (it being the second instance of that folder in the trash).
Thunderbird popped up an error message. On an imap host:
The current command did not succeed. The mail server responded: Mailbox
already exists.
In the local folders:
A folder with that name already exists. Please enter a different name (!)
Workarounds:
1. Empty the trash
2. Rename the folder before deletion
3. Rename the folder already in the trash
4. Delete (permanently) the folder that is already in the trash
Ubuntu 7.10 Gutsy
thunderbird 2.0.0.12+nobinonly-0ubuntu0.7.10.0
To manage notifications about this bug go to:
https://bugs.launchpad.net/thunderbird/+bug/214366/+subscriptions
--
Mailing list: https://launchpad.net/~desktop-packages
Post to : [email protected]
Unsubscribe : https://launchpad.net/~desktop-packages
More help : https://help.launchpad.net/ListHelp
