Comment on attachment 497112
Use EXTEND_PAD on X

Tested <http://hg.mozilla.org/mozilla-central/rev/5d9e1a56d922> on my
current Linux box: X server vendor release code 10707000, Nouveau driver
0.0.16, NV94 video chipset.

The test case in attachment 351955 shows display artifacts:

* with an unmodified tree;
* with joe's patches for this bug and bug 566283;
* and even with PreparePatternForUntiledDrawing chainsawed down to just

{
    aPattern->SetExtend(gfxPattern::EXTEND_PAD);
    aPattern->SetFilter(aDefaultFilter);
}

The artifacts are not the same as what I get with 3.6 on the same
hardware.  3.6 shows thin green lines, all the same color throughout,
some of which have solid black dots at their right edges; at some zoom
levels there are also solid black lines underneath the green line (with
a white pixel or two in between).

mozilla-central never produces the solid black dots at the right edges;
however, the green lines are not all the same color throughout, they are
the proper color in the middle, and fade to neutral gray at both edges.
Some of the lines get black lines underneath them.  And they all appear
to be slightly fatter than they were in 3.6.  This behavior is more or
less the same regardless of whether any patches are applied (the patch
seems to change subtleties of the artifacts).

It is plausible to me that this is a bug in nouveau, and honestly I
think the correct course of action at this point is to nuke the entire
mess, use EXTEND_PAD unconditionally, and then work with the Cairo and X
driver folks to figure out what's still wrong and fix it properly.
Nonetheless I cannot say that this patch fixes the original problem.

-- 
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to firefox in Ubuntu.
https://bugs.launchpad.net/bugs/263661

Title:
  Black Line appears next to gif and png images

Status in The Mozilla Firefox Browser:
  Fix Released
Status in “firefox” package in Ubuntu:
  Fix Released

Bug description:
  Binary package hint: firefox-3.0

  A few of my web sites, when viewed after upgrading to firefox-3.0 (on
  Ubuntu 8.04), display a vertical black line next to some GIF images
  (created in Gimp). The only time I see this line is next to 1 pixel
  wide images stretched (used as spacers). I noticed that after
  stretching past a specific width (different for the each occurrence) a
  1 pixel wide black line would appear just next to the GIF. It would
  appear sometimes to the left, sometimes to the right, depending on the
  stretched width of the image.

  I was able to remedy this by using 3 shorter width images instead of
  one long width image, but this is obviously not a real fix. Please
  note that same sites did not show this black line before upgrading to
  firefox-3.0.

  ----
  Package details:
  firefox-3.0:
    Installed: 3.0.1+build1+nobinonly-0ubuntu0.8.04.3
    Candidate: 3.0.1+build1+nobinonly-0ubuntu0.8.04.3
    Version table:
   *** 3.0.1+build1+nobinonly-0ubuntu0.8.04.3 0
          500 http://security.ubuntu.com hardy-security/main Packages
          500 http://archive.ubuntu.com hardy-updates/main Packages
          100 /var/lib/dpkg/status
       3.0~b5+nobinonly-0ubuntu3 0
          500 http://archive.ubuntu.com hardy/main Packages

  ProblemType: Bug
  Architecture: i386
  Date: Mon Sep  1 09:44:58 2008
  DistroRelease: Ubuntu 8.04
  NonfreeKernelModules: nvidia
  Package: firefox-3.0 3.0.1+build1+nobinonly-0ubuntu0.8.04.3
  PackageArchitecture: i386
  ProcEnviron:
   PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games
   LANG=en_US.UTF-8
   SHELL=/bin/bash
  SourcePackage: firefox-3.0
  Uname: Linux 2.6.24-21-generic i686

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/263661/+subscriptions

-- 
Mailing list: https://launchpad.net/~desktop-packages
Post to     : [email protected]
Unsubscribe : https://launchpad.net/~desktop-packages
More help   : https://help.launchpad.net/ListHelp

Reply via email to